diff options
| author | Aaron Durbin <adurbin@chromium.org> | 2019-08-27 20:22:40 -0600 |
|---|---|---|
| committer | Aaron Durbin <adurbin@chromium.org> | 2019-08-28 13:34:19 +0000 |
| commit | df2bfb9a1ae5873283f644111ca4ef378fbd3c1a (patch) | |
| tree | 5e62257ecfd40d2ee93320a6dff4946b55d7bce5 | |
| parent | 1225afe4829eb3e6de48e9409e318aef4bb22f0b (diff) | |
| download | coreboot-df2bfb9a1ae5873283f644111ca4ef378fbd3c1a.tar.xz | |
arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol
postcar_commit_mtrrs() isn't used outside the postcar_loader
compilation unit. Make it static to reduce API surface area.
Additionally the return value was not being utilized. Modify
the return type to be void to align with the current usage.
Change-Id: If07f34467941d00de731489867e485cfff80ea63
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35130
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
| -rw-r--r-- | src/arch/x86/include/arch/romstage.h | 6 | ||||
| -rw-r--r-- | src/arch/x86/postcar_loader.c | 3 |
2 files changed, 1 insertions, 8 deletions
diff --git a/src/arch/x86/include/arch/romstage.h b/src/arch/x86/include/arch/romstage.h index 7816a7c0bc..2ac225875f 100644 --- a/src/arch/x86/include/arch/romstage.h +++ b/src/arch/x86/include/arch/romstage.h @@ -58,12 +58,6 @@ void postcar_frame_add_romcache(struct postcar_frame *pcf, int type); void postcar_frame_common_mtrrs(struct postcar_frame *pcf); /* - * Push used MTRR and Max MTRRs on to the stack - * and return pointer to stack top. - */ -void *postcar_commit_mtrrs(struct postcar_frame *pcf); - -/* * fill_postcar_frame() is called after raminit completes and right before * calling run_postcar_phase(). Implementation should call postcar_frame_add_mtrr() * to tag memory ranges as cacheable to speed up execution of postcar and diff --git a/src/arch/x86/postcar_loader.c b/src/arch/x86/postcar_loader.c index 4a7d549347..6a7d389ea3 100644 --- a/src/arch/x86/postcar_loader.c +++ b/src/arch/x86/postcar_loader.c @@ -147,7 +147,7 @@ void prepare_and_run_postcar(struct postcar_frame *pcf) /* We do not return here. */ } -void *postcar_commit_mtrrs(struct postcar_frame *pcf) +static void postcar_commit_mtrrs(struct postcar_frame *pcf) { /* * Place the number of used variable MTRRs on stack then max number @@ -155,7 +155,6 @@ void *postcar_commit_mtrrs(struct postcar_frame *pcf) */ stack_push(pcf, pcf->num_var_mtrrs); stack_push(pcf, pcf->max_var_mtrrs); - return (void *) pcf->stack; } static void finalize_load(uintptr_t *stack_top_ptr, uintptr_t stack_top) |