summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2019-01-12 15:05:20 +0100
committerNico Huber <nico.h@gmx.de>2019-01-13 14:01:19 +0000
commit15b83da39a90ebfcc85ca3d18325ab00e8d3a26c (patch)
tree8f669778c79977e326057f5d495b3d236f71e663
parent4e008c699b3db0263b1b4a89d7cc53c4180b09cb (diff)
downloadcoreboot-15b83da39a90ebfcc85ca3d18325ab00e8d3a26c.tar.xz
nb/intel/x4x: Remove spurious pcidev_on_root() usage
It's supposed to be the same device that is passed to the executing function. Change-Id: I6cf994390c16e0393c96a2b2e04a36305be88e68 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/30880 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
-rw-r--r--src/northbridge/intel/x4x/gma.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c
index 680b83698b..4c27634955 100644
--- a/src/northbridge/intel/x4x/gma.c
+++ b/src/northbridge/intel/x4x/gma.c
@@ -60,7 +60,6 @@ void gma_set_gnvs_aslb(void *gnvs, uintptr_t aslb)
static void gma_func0_init(struct device *dev)
{
- u16 reg16;
u32 reg32;
/* IGD needs to be Bus Master */
@@ -69,10 +68,7 @@ static void gma_func0_init(struct device *dev)
pci_write_config32(dev, PCI_COMMAND, reg32);
/* configure GMBUSFREQ */
- reg16 = pci_read_config16(pcidev_on_root(0x2, 0), 0xcc);
- reg16 &= ~0x1ff;
- reg16 |= 0xbc;
- pci_write_config16(pcidev_on_root(0x2, 0), 0xcc, reg16);
+ pci_update_config16(dev, 0xcc, ~0x1ff, 0xbc);
int vga_disable = (pci_read_config16(dev, D0F0_GGC) & 2) >> 1;