diff options
| author | Martin Roth <martinroth@google.com> | 2016-04-13 12:20:52 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2016-04-13 23:39:28 +0200 |
| commit | a2f4758900dcfbebf54447acea2aeee678c5f018 (patch) | |
| tree | 96d320380ddd4aae0c3f93f9725c8d7ebfc0a952 | |
| parent | fbec1ad4efbdd01759cd4d2e22d27281bd5b1626 (diff) | |
| download | coreboot-a2f4758900dcfbebf54447acea2aeee678c5f018.tar.xz | |
superio/smsc/mec1308: Fix AddressMax value for SMBX mailbox
The way this was implemented before was causing ACPI failures. There
was also a basic misunderstanding of what the AddressMax field was used
for. In this case, because it's a fixed address, it should be the same
as the AddressMin field.
Getting rid of the addition in the field solves the ACPI output problem.
Change-Id: Idec2bf0ed27ae694e98f141087cdf22401937178
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/14343
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Idwer Vollering <vidwer@gmail.com>
Reviewed-by: Duncan Laurie <dlaurie@google.com>
| -rw-r--r-- | src/superio/smsc/mec1308/acpi/superio.asl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl index 6794448766..cc174f96ae 100644 --- a/src/superio/smsc/mec1308/acpi/superio.asl +++ b/src/superio/smsc/mec1308/acpi/superio.asl @@ -246,12 +246,12 @@ Device (SIO) { Name (_CRS, ResourceTemplate() { - IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34) + IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) }) Name (_PRS, ResourceTemplate() { - IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0 + 0x34, 0x01, 0x34) + IO (Decode16, SIO_SMBX_IO0, SIO_SMBX_IO0, 0x01, 0x34) }) } #endif |