diff options
| author | Matt DeVillier <matt.devillier@gmail.com> | 2017-05-30 14:25:32 -0400 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2017-06-09 17:01:41 +0200 |
| commit | ab5b4c19c31d34ebb1ab697089f3626c50d2d801 (patch) | |
| tree | 49d4438ad588cc8e0cf7e405372703a152c34810 | |
| parent | 2f48b7b1e9e3d0a631c7d8951c1a5b5dc748df09 (diff) | |
| download | coreboot-ab5b4c19c31d34ebb1ab697089f3626c50d2d801.tar.xz | |
purism/librem13v1: Set FADT revision to ACPI 3.0
The FADT revision was set to 5, but we do not implement the
ACPI v5.0 specification, which prevents Windows from booting.
Setting it to v3 (matching most other boards) fixes the issue
and Windows now boots normally.
Bug found by Matt DeVillier, fix tested by Youness Alaoui on
Librem 13 v1 hardware.
Please also see commits 00d250e2289de (intel/skylake: Switch FADT
to ACPI version 3.0) [1] and 27e6042bb7d0b1 (intel/apollolake:
Switch FADT to ACPI version 3.0) [2].
[1] https://review.coreboot.org/19453
[2] https://review.coreboot.org/19146
Change-Id: Ide97cbf64f7b05018433436431ab4723b217fe22
Signed-off-by: Youness Alaoui <youness.alaoui@puri.sm>
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/19985
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
| -rw-r--r-- | src/mainboard/purism/librem13v1/fadt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mainboard/purism/librem13v1/fadt.c b/src/mainboard/purism/librem13v1/fadt.c index 980ff03a0f..9cbcd3f4f0 100644 --- a/src/mainboard/purism/librem13v1/fadt.c +++ b/src/mainboard/purism/librem13v1/fadt.c @@ -23,7 +23,7 @@ void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) memset(fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 5; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4); |