diff options
| author | Peter Lemenkov <lemenkov@gmail.com> | 2019-10-22 18:36:59 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2019-10-25 07:02:02 +0000 |
| commit | b2832e3586530361cf92bdf55d060365fdcdf44c (patch) | |
| tree | 130ff460acb0552d16f4295c2b089a527f542028 | |
| parent | 8c09b82cb19932990956810533f159ddbc64d5fc (diff) | |
| download | coreboot-b2832e3586530361cf92bdf55d060365fdcdf44c.tar.xz | |
mb/*/*/smihandler: Remove bogus SMM init
I does nothing on these boards. It's just a call a local noop function
which only prints a debug-level message.
Change-Id: Id3fb2e9074db72d9025b95f7d4918417dd488b9e
Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36236
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
| -rw-r--r-- | src/mainboard/apple/macbook21/smihandler.c | 12 | ||||
| -rw-r--r-- | src/mainboard/lenovo/s230u/smihandler.c | 12 | ||||
| -rw-r--r-- | src/mainboard/packardbell/ms2290/smihandler.c | 12 |
3 files changed, 0 insertions, 36 deletions
diff --git a/src/mainboard/apple/macbook21/smihandler.c b/src/mainboard/apple/macbook21/smihandler.c index 88cc4c0eb6..adb48db6dc 100644 --- a/src/mainboard/apple/macbook21/smihandler.c +++ b/src/mainboard/apple/macbook21/smihandler.c @@ -21,20 +21,8 @@ #define GPE_EC_SCI 12 -static void mainboard_smm_init(void) -{ - printk(BIOS_DEBUG, "initializing SMI\n"); -} - int mainboard_io_trap_handler(int smif) { - static int smm_initialized; - - if (!smm_initialized) { - mainboard_smm_init(); - smm_initialized = 1; - } - switch (smif) { default: return 0; diff --git a/src/mainboard/lenovo/s230u/smihandler.c b/src/mainboard/lenovo/s230u/smihandler.c index 3c4df31f08..1abf0c88a7 100644 --- a/src/mainboard/lenovo/s230u/smihandler.c +++ b/src/mainboard/lenovo/s230u/smihandler.c @@ -32,20 +32,8 @@ /* FIXME: check this */ #define GPE_EC_WAKE 13 -static void mainboard_smm_init(void) -{ - printk(BIOS_DEBUG, "initializing SMI\n"); -} - int mainboard_io_trap_handler(int smif) { - static int smm_initialized; - - if (!smm_initialized) { - mainboard_smm_init(); - smm_initialized = 1; - } - return 0; } diff --git a/src/mainboard/packardbell/ms2290/smihandler.c b/src/mainboard/packardbell/ms2290/smihandler.c index dfc66f98cf..915de13de1 100644 --- a/src/mainboard/packardbell/ms2290/smihandler.c +++ b/src/mainboard/packardbell/ms2290/smihandler.c @@ -22,20 +22,8 @@ #include <northbridge/intel/nehalem/nehalem.h> #include <ec/acpi/ec.h> -static void mainboard_smm_init(void) -{ - printk(BIOS_DEBUG, "initializing SMI\n"); -} - int mainboard_io_trap_handler(int smif) { - static int smm_initialized; - - if (!smm_initialized) { - mainboard_smm_init(); - smm_initialized = 1; - } - switch (smif) { default: |