summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSubrata Banik <subrata.banik@intel.com>2017-03-23 11:52:59 +0530
committerAaron Durbin <adurbin@chromium.org>2017-03-24 14:48:16 +0100
commitc790850ebe81d5b9fd7018b41e2fd7bda79db8c1 (patch)
treea1cecdab27f0c1b9098dc13825bc5aa97440593b
parent6e260fc873d38f2b836402e58c8660160b159e60 (diff)
downloadcoreboot-c790850ebe81d5b9fd7018b41e2fd7bda79db8c1.tar.xz
soc/intel/apollolake: Remove unused CAR_GLOBAL variable
Also move all local variable declaration at starting of function block. Change-Id: I774485a23b4b7d96a8dbd837da45553251dff3b0 Signed-off-by: Subrata Banik <subrata.banik@intel.com> Reviewed-on: https://review.coreboot.org/18949 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
-rw-r--r--src/soc/intel/apollolake/mmap_boot.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/src/soc/intel/apollolake/mmap_boot.c b/src/soc/intel/apollolake/mmap_boot.c
index a92fbb3fc8..50d0ff0590 100644
--- a/src/soc/intel/apollolake/mmap_boot.c
+++ b/src/soc/intel/apollolake/mmap_boot.c
@@ -58,7 +58,6 @@
*
*/
-static size_t bios_start CAR_GLOBAL;
static size_t bios_size CAR_GLOBAL;
static struct mem_region_device shadow_dev CAR_GLOBAL;
@@ -66,7 +65,8 @@ static struct xlate_region_device real_dev CAR_GLOBAL;
static void bios_mmap_init(void)
{
- size_t size;
+ size_t size, start, bios_end, bios_mapped_size;
+ uintptr_t base;
size = car_get_var(bios_size);
@@ -74,9 +74,6 @@ static void bios_mmap_init(void)
if (size != 0)
return;
- size_t start, bios_end, bios_mapped_size;
- uintptr_t base;
-
/*
* BIOS_BFPREG provides info about BIOS Flash Primary Region
* Base and Limit.
@@ -110,7 +107,6 @@ static void bios_mmap_init(void)
start, bios_mapped_size,
CONFIG_ROM_SIZE);
- car_set_var(bios_start, start);
car_set_var(bios_size, size);
}