diff options
| author | Sven Schnelle <svens@stackframe.org> | 2011-10-25 15:29:47 +0200 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2011-10-25 17:48:41 +0200 |
| commit | d0ea6789e6e07fc9611be157e178df53ec5500e4 (patch) | |
| tree | bade80507267f08a73504583622089a35cbd5486 | |
| parent | 2b1fbbbc897af573af66f48d75862559334f7055 (diff) | |
| download | coreboot-d0ea6789e6e07fc9611be157e178df53ec5500e4.tar.xz | |
Lenovo H8: Fix h8_set_audio_mute()
Logic is inverted (if argument is true, one would expect that
mute is enabled) and the wrong bit was used (1 instead 0)
Change-Id: I71133ba639f1fb0d3c3582f16211dd266a11cc64
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-on: http://review.coreboot.org/334
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
| -rw-r--r-- | src/ec/lenovo/h8/h8.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 560c39cb87..f81a39cb24 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -63,12 +63,12 @@ static void h8_log_ec_version(void) fwvh >> 4, fwvh & 0x0f, fwvl >> 4, 0x41 + (fwvl & 0xf)); } -void h8_set_audio_mute(int on) +void h8_set_audio_mute(int mute) { - if (on) - ec_clr_bit(0x3a, 0); + if (mute) + ec_set_bit(0x3a, 0); else - ec_set_bit(0x3a, 1); + ec_clr_bit(0x3a, 0); } void h8_enable_event(int event) |