diff options
author | Angel Pons <th3fanbus@gmail.com> | 2020-06-20 18:01:57 +0200 |
---|---|---|
committer | Angel Pons <th3fanbus@gmail.com> | 2020-08-07 11:57:32 +0000 |
commit | 159d0f0ed7302b214e2e43c5c6041f3d598aab66 (patch) | |
tree | c5c63cad654697ea167aca40bc1fc73a0101901c | |
parent | 2f1739ada8a32a70dbd5a3fd1a3d6fd5fba6d291 (diff) | |
download | coreboot-159d0f0ed7302b214e2e43c5c6041f3d598aab66.tar.xz |
soc/intel/broadwell/iobp: Log success in `pch_iobp_write()`
This reduces the differences between Lynxpoint and Broadwell.
Change-Id: I759aa98b80c70c5024213bd8795375061bdbbf10
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42622
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r-- | src/soc/intel/broadwell/iobp.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/soc/intel/broadwell/iobp.c b/src/soc/intel/broadwell/iobp.c index 76a3e58c3e..ffa61fbce5 100644 --- a/src/soc/intel/broadwell/iobp.c +++ b/src/soc/intel/broadwell/iobp.c @@ -91,8 +91,12 @@ void pch_iobp_write(u32 address, u32 data) /* Check for successful transaction */ status = RCBA16(IOBPS); - if (status & IOBPS_TX_MASK) + if (status & IOBPS_TX_MASK) { printk(BIOS_ERR, "IOBP: write 0x%08x failed\n", address); + return; + } + + printk(BIOS_INFO, "IOBP: set 0x%08x to 0x%08x\n", address, data); } void pch_iobp_update(u32 address, u32 andvalue, u32 orvalue) |