summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWerner Zeh <werner.zeh@siemens.com>2020-04-21 11:03:11 +0200
committerPatrick Georgi <pgeorgi@google.com>2020-04-22 17:33:03 +0000
commit21530bd421ed286939c32edc8c8cc451ede2e3a7 (patch)
tree158d547618d293b965e417c0abc23e1121e22223
parentabaa1de93b36a431e5545f252cddc0e1c2cd3102 (diff)
downloadcoreboot-21530bd421ed286939c32edc8c8cc451ede2e3a7.tar.xz
util/scripts/ucode_h_to_bin.sh: Drop disruptive quotes
The double quotes around the remaining shell parameters '${@:2}' causes that the provided *.h files in $(CONFIG_CPU_MICROCODE_HEADER_FILES), which is a space separated list, cannot be broken down to every single file as needed but stay as a single parameter in the for-loop. Therefore, the called function 'include_file' will get a single parameter with all files which will lead to a broken C code in terms of a wrong #include-syntax. This causes the script to fail. To fix this remove the double quotes which works just fine. Change-Id: Iab7b0dc8d850973d6af764899907d383e9ec7743 Signed-off-by: Werner Zeh <werner.zeh@siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40565 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
-rwxr-xr-xutil/scripts/ucode_h_to_bin.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/util/scripts/ucode_h_to_bin.sh b/util/scripts/ucode_h_to_bin.sh
index e6f4699c8f..2010c48e36 100755
--- a/util/scripts/ucode_h_to_bin.sh
+++ b/util/scripts/ucode_h_to_bin.sh
@@ -49,7 +49,7 @@ include_file() {
fi
}
-for UCODE in "${@:2}"; do
+for UCODE in ${@:2}; do
if [ -d "$UCODE" ]; then
for f in "$UCODE/"*.inc
do