diff options
| author | Paul Menzel <pmenzel@molgen.mpg.de> | 2017-03-11 15:11:36 +0100 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2017-03-11 17:43:17 +0100 |
| commit | 4eb155cee47557cd652d1a85fed5021b23f18a2a (patch) | |
| tree | 453a50939b0dbf081fda42641e1addef7ca0cfa7 | |
| parent | 9ab5adbde4c3eb820e5f88db765fac33eb30bd97 (diff) | |
| download | coreboot-4eb155cee47557cd652d1a85fed5021b23f18a2a.tar.xz | |
lenovo/t400/dock.c: Fix issues found by checkpatch.pl
Change-Id: If7ebab8af1ae0c048cb89c2feb5f6a65848b6952
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-on: https://review.coreboot.org/18767
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
| -rw-r--r-- | src/mainboard/lenovo/t400/dock.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/src/mainboard/lenovo/t400/dock.c b/src/mainboard/lenovo/t400/dock.c index a3412bf4d0..65dd6f0514 100644 --- a/src/mainboard/lenovo/t400/dock.c +++ b/src/mainboard/lenovo/t400/dock.c @@ -58,7 +58,7 @@ static int gpio_init(pnp_devfn_t gpio, u16 gpio_base, pnp_set_iobase(gpio, PNP_IDX_IO0, gpio_base); pnp_set_enable(gpio, 1); - for (i=0; i < num_cfgs; i++) { + for (i = 0; i < num_cfgs; i++) { pnp_write_config(gpio, 0xf0, pincfg[i].port); pnp_write_config(gpio, 0xf1, pincfg[i].mode); pnp_write_config(gpio, 0xf2, 0x0); @@ -92,7 +92,7 @@ static int pc87382_init(pnp_devfn_t dlpc, u16 dlpc_base) /* Reset docking state */ outb(0x00, dlpc_base); outb(0x07, dlpc_base); - while(!(inb(dlpc_base) & 8) && timeout--) + while (!(inb(dlpc_base) & 8) && timeout--) udelay(1000); if (!timeout) return 1; @@ -111,7 +111,7 @@ static void pc87382_close(pnp_devfn_t dlpc) } static const struct pin_config local_gpio[] = { - {0x00, 3}, {0x01, 3}, {0x02, 0}, {0x03, 3}, + {0x00, 3}, {0x01, 3}, {0x02, 0}, {0x03, 3}, {0x04, 4}, {0x20, 4}, {0x21, 4}, {0x23, 4}, }; @@ -132,9 +132,8 @@ static int pc87382_connect(void) /* Deassert D_PLTRST# and D_LPCPD# */ outb(reg, DLPC_GPDO0); - if (pc87382_init(l_dlpc, DLPC_CONTROL) != 0) { + if (pc87382_init(l_dlpc, DLPC_CONTROL) != 0) return 1; - } /* Assert D_PLTRST# */ reg &= ~D_PLTRST; @@ -144,7 +143,7 @@ static int pc87382_connect(void) /* Deassert D_PLTRST# */ reg |= D_PLTRST; outb(reg, DLPC_GPDO0); - udelay(10000); + mdelay(10); return 0; } |