summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niewöhner <foss@mniewoehner.de>2019-10-27 19:52:23 +0100
committerArthur Heymans <arthur@aheymans.xyz>2019-10-28 18:54:13 +0000
commit7f57dd4b654f001cfcdd34b6faa05a2d5b89576c (patch)
treec48ef0bc7b4699f4f46147eb69f3989808d9ade4
parent0108c8b742bd7a3a7c2db8357677211e7eb14fac (diff)
downloadcoreboot-7f57dd4b654f001cfcdd34b6faa05a2d5b89576c.tar.xz
src/soc/intel: skl,cnl,icl: remove unneeded check in cbmem_top()
As stated in CB:36334 cbmem_top() should not be called before memory is initialized. Therefore drop the check to see if MRC finished. Change-Id: I964a20a5e9aa69fdb75413c36a17d34b7ba00098 Signed-off-by: Michael Niewöhner <foss@mniewoehner.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36386 Reviewed-by: Arthur Heymans <arthur@aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/soc/intel/cannonlake/memmap.c9
-rw-r--r--src/soc/intel/icelake/memmap.c9
-rw-r--r--src/soc/intel/skylake/memmap.c9
3 files changed, 0 insertions, 27 deletions
diff --git a/src/soc/intel/cannonlake/memmap.c b/src/soc/intel/cannonlake/memmap.c
index 2239f137c1..80aa97dc9b 100644
--- a/src/soc/intel/cannonlake/memmap.c
+++ b/src/soc/intel/cannonlake/memmap.c
@@ -257,15 +257,6 @@ void *cbmem_top(void)
{
struct ebda_config ebda_cfg;
- /*
- * Check if Tseg has been initialized, we will use this as a flag
- * to check if the MRC is done, and only then continue to read the
- * PRMMR_BASE MSR. The system hangs if PRMRR_BASE MSR is read before
- * PRMRR_MASK MSR lock bit is set.
- */
- if (sa_get_tseg_base() == 0)
- return NULL;
-
retrieve_ebda_object(&ebda_cfg);
return (void *)(uintptr_t)ebda_cfg.tolum_base;
diff --git a/src/soc/intel/icelake/memmap.c b/src/soc/intel/icelake/memmap.c
index 122cb1a009..00f45cf3ed 100644
--- a/src/soc/intel/icelake/memmap.c
+++ b/src/soc/intel/icelake/memmap.c
@@ -236,15 +236,6 @@ void *cbmem_top(void)
{
struct ebda_config ebda_cfg;
- /*
- * Check if Tseg has been initialized, we will use this as a flag
- * to check if the MRC is done, and only then continue to read the
- * PRMMR_BASE MSR. The system hangs if PRMRR_BASE MSR is read before
- * PRMRR_MASK MSR lock bit is set.
- */
- if (sa_get_tseg_base() == 0)
- return NULL;
-
retrieve_ebda_object(&ebda_cfg);
return (void *)(uintptr_t)ebda_cfg.tolum_base;
diff --git a/src/soc/intel/skylake/memmap.c b/src/soc/intel/skylake/memmap.c
index 780c73c298..c6ccd71c1e 100644
--- a/src/soc/intel/skylake/memmap.c
+++ b/src/soc/intel/skylake/memmap.c
@@ -258,15 +258,6 @@ void *cbmem_top(void)
{
struct ebda_config ebda_cfg;
- /*
- * Check if Tseg has been initialized, we will use this as a flag
- * to check if the MRC is done, and only then continue to read the
- * PRMMR_BASE MSR. The system hangs if PRMRR_BASE MSR is read before
- * PRMRR_MASK MSR lock bit is set.
- */
- if (sa_get_tseg_base() == 0)
- return NULL;
-
retrieve_ebda_object(&ebda_cfg);
return (void *)(uintptr_t)ebda_cfg.tolum_base;