summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSubrata Banik <subrata.banik@intel.com>2020-03-25 18:40:41 +0530
committerSubrata Banik <subrata.banik@intel.com>2020-03-27 05:39:37 +0000
commit90557f4a4ba8ffc027bf16a3a43db4ebb35072f9 (patch)
tree9e5e40593d77d6ff960e1fcd785dfb2f9e025413
parentd4e9978793f1663db1557f13b81e371dfad0eb96 (diff)
downloadcoreboot-90557f4a4ba8ffc027bf16a3a43db4ebb35072f9.tar.xz
drivers/intel/fsp2_0: Avoid iterative print statement
This patch moves "Display FSP Version Info HOB" print outside of the loop to avoid getting called multiple times. TEST=Able to see "Display FSP Version Info HOB" only once. Change-Id: I754d5922f4dbef22656ca98c02d9f45791c8433d Signed-off-by: Subrata Banik <subrata.banik@intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39827 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Furquan Shaikh <furquan@google.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--src/drivers/intel/fsp2_0/hand_off_block.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c
index d2c2b784cf..3978a1848b 100644
--- a/src/drivers/intel/fsp2_0/hand_off_block.c
+++ b/src/drivers/intel/fsp2_0/hand_off_block.c
@@ -233,7 +233,6 @@ static void display_fsp_version_info_hob(const void *hob, size_t size)
(fvih->Count * sizeof (FIRMWARE_VERSION_INFO)));
size -= sizeof(SMBIOS_STRUCTURE);
- printk(BIOS_DEBUG, "Display FSP Version Info HOB\n");
for (index = 0; index < fvih->Count; index++) {
cnt = strlen(str_ptr);
@@ -282,6 +281,7 @@ void fsp_display_fvi_version_hob(void)
if (!hob)
return;
+ printk(BIOS_DEBUG, "Display FSP Version Info HOB\n");
for (; hob->type != HOB_TYPE_END_OF_HOB_LIST;
hob = fsp_next_hob(hob)) {
if (hob->type != HOB_TYPE_GUID_EXTENSION)