diff options
| author | Cheng-Yi Chiang <cychiang@chromium.org> | 2019-10-23 16:29:41 +0800 |
|---|---|---|
| committer | Duncan Laurie <dlaurie@chromium.org> | 2019-10-25 03:12:00 +0000 |
| commit | 9680b84eb1c892d5fdb32539ede541af33554306 (patch) | |
| tree | de663341ec380ad895219903bf082e747e888bb3 | |
| parent | 489c10ee5440981c6a2b06e13a856aa4fd6d07e7 (diff) | |
| download | coreboot-9680b84eb1c892d5fdb32539ede541af33554306.tar.xz | |
mb/google/hatch: Fix speaker mapping for Helios
The correct mapping for speakers to their names should be:
uid 0: Woofer Left
uid 1: Woofer Right
uid 2: Tweeter Left
uid 3: Tweeter Right
Also, fix the name to be 4-character.
BUG=b:140397934, b:143192767
BRANCH=none
TEST=On Helios, with patch series, check realtek,r0_calib and
realtek,temperature_calib are available to rt1011 codec driver.
And the speaker mapping is correct.
Change-Id: I353fb9ad0ca8ec85431eb2b59be748b4887278cf
Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36256
Reviewed-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/google/hatch/variants/helios/overridetree.cb | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 0902340e56..8dcb049274 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -147,30 +147,30 @@ chip soc/intel/cannonlake end chip drivers/i2c/generic register "hid" = ""10EC1011"" - register "desc" = ""RT1011 Tweeter Left Speaker Amp"" + register "desc" = ""RT1011 Woofer Left Speaker Amp"" register "uid" = "0" - register "name" = ""TL"" + register "name" = ""RTWL"" device i2c 38 on end end chip drivers/i2c/generic register "hid" = ""10EC1011"" - register "desc" = ""RT1011 Tweeter Right Speaker Amp"" + register "desc" = ""RT1011 Woofer Right Speaker Amp"" register "uid" = "1" - register "name" = ""TR"" + register "name" = ""RTWR"" device i2c 39 on end end chip drivers/i2c/generic register "hid" = ""10EC1011"" - register "desc" = ""RT1011 Woofer Left Speaker Amp"" + register "desc" = ""RT1011 Tweeter Left Speaker Amp"" register "uid" = "2" - register "name" = ""WL"" + register "name" = ""RTTL"" device i2c 3a on end end chip drivers/i2c/generic register "hid" = ""10EC1011"" - register "desc" = ""RT1011 Woofer Right Speaker Amp"" + register "desc" = ""RT1011 Tweeter Right Speaker Amp"" register "uid" = "3" - register "name" = ""WR"" + register "name" = ""RTTR"" device i2c 3b on end end end #I2C #4 |