diff options
| author | Nico Huber <nico.h@gmx.de> | 2018-06-05 22:34:08 +0200 |
|---|---|---|
| committer | Patrick Georgi <pgeorgi@google.com> | 2018-06-11 08:43:30 +0000 |
| commit | 9e53db4dc32da0aae986e4813401d5a92c2bb0fd (patch) | |
| tree | b12080b2cf96884744f0e04605ea2d805e247cd1 | |
| parent | 1d017363c4fe44af4ede6cbfdf0f950ee5c6722d (diff) | |
| download | coreboot-9e53db4dc32da0aae986e4813401d5a92c2bb0fd.tar.xz | |
drivers/spi: Remove Kconfig prompt from SPI_FLASH_SMM
Why would that be a user visible option? Drop the prompt and the
`default n` and select it automatically when needed. I hope I
caught all its users.
TEST=Confirmed that systems with ELOG_GSMI or DEBUG_SMI compile
and link.
Change-Id: I44aeec530cc333f4ed4c8cfe67c7b5c9d8fb0049
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/26872
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
| -rw-r--r-- | src/Kconfig | 2 | ||||
| -rw-r--r-- | src/drivers/elog/Kconfig | 1 | ||||
| -rw-r--r-- | src/drivers/spi/Kconfig | 3 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/Kconfig b/src/Kconfig index 4465a6b0dc..fd0a4eb9a6 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -748,7 +748,7 @@ config DEBUG_SMI bool "Output verbose SMI debug messages" default n depends on HAVE_SMI_HANDLER - select SPI_FLASH_SMM if SPI_CONSOLE + select SPI_FLASH_SMM if SPI_CONSOLE || CONSOLE_SPI_FLASH help This option enables additional SMI related debug messages. diff --git a/src/drivers/elog/Kconfig b/src/drivers/elog/Kconfig index c7bed75059..c5ff7aeffe 100644 --- a/src/drivers/elog/Kconfig +++ b/src/drivers/elog/Kconfig @@ -41,6 +41,7 @@ endif config ELOG_GSMI depends on ELOG && SMM_TSEG bool "SMI interface to write and clear event log" + select SPI_FLASH_SMM if BOOT_DEVICE_SPI_FLASH_RW_NOMMAP default n help This interface is compatible with the linux kernel driver diff --git a/src/drivers/spi/Kconfig b/src/drivers/spi/Kconfig index c8d86ff104..b15a502cfd 100644 --- a/src/drivers/spi/Kconfig +++ b/src/drivers/spi/Kconfig @@ -62,8 +62,7 @@ config SPI_FLASH_INCLUDE_ALL_DRIVERS default y config SPI_FLASH_SMM - bool "SPI flash driver support in SMM" - default n + bool depends on HAVE_SMI_HANDLER help Select this option if you want SPI flash support in SMM. |