summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2019-11-18 18:21:27 -0800
committerJulius Werner <jwerner@chromium.org>2019-11-19 06:17:04 +0000
commit9f19dd9f617a6167442fac536d628b04471de59a (patch)
tree8b7a24b8ee9bb437438bfee907a31d0b7d83a9e0
parenta2148377b5605e96860476bd7cffbabc6e92542e (diff)
downloadcoreboot-9f19dd9f617a6167442fac536d628b04471de59a.tar.xz
mmio: Fix buffer_to_fifo32() order of arguments
buffer_to_fifo32() is a simple wrapper to buffer_to_fifo32_prefix(), but unfortunately its arguments are swapped. This patch fixes the issue. Change-Id: I6414bf51dd9de681b3b87bbaf4ea4efc815f7ae1 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/36942 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--payloads/libpayload/include/libpayload.h2
-rw-r--r--src/include/device/mmio.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h
index bfe9da5f40..0bd5db8257 100644
--- a/payloads/libpayload/include/libpayload.h
+++ b/payloads/libpayload/include/libpayload.h
@@ -458,7 +458,7 @@ void buffer_to_fifo32_prefix(void *buffer, u32 prefix, int prefsz, size_t size,
static inline void buffer_to_fifo32(void *buffer, size_t size, void *fifo,
int fifo_stride, int fifo_width)
{
- buffer_to_fifo32_prefix(buffer, size, 0, 0, fifo,
+ buffer_to_fifo32_prefix(buffer, 0, 0, size, fifo,
fifo_stride, fifo_width);
}
#endif
diff --git a/src/include/device/mmio.h b/src/include/device/mmio.h
index df36eb6f96..6596cf89ed 100644
--- a/src/include/device/mmio.h
+++ b/src/include/device/mmio.h
@@ -48,7 +48,7 @@ void buffer_to_fifo32_prefix(void *buffer, u32 prefix, int prefsz, size_t size,
static inline void buffer_to_fifo32(void *buffer, size_t size, void *fifo,
int fifo_stride, int fifo_width)
{
- buffer_to_fifo32_prefix(buffer, size, 0, 0, fifo,
+ buffer_to_fifo32_prefix(buffer, 0, 0, size, fifo,
fifo_stride, fifo_width);
}