summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulius Werner <jwerner@chromium.org>2020-08-21 15:20:02 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-08-24 09:24:06 +0000
commitae096be00c3ada5acc6dfd601a1ad2bb36e234db (patch)
tree9fcb34c8453d386c88e147fb242b791f87de5696
parent0c12abe4625e9bde9b31cbd9b1b9e2727bdee715 (diff)
downloadcoreboot-ae096be00c3ada5acc6dfd601a1ad2bb36e234db.tar.xz
libpayload: memmove: Don't make expectations of architecture memcpy
default_memmove() calls memcpy() when (src > dst). This is safe for the default_memcpy() implementation, but just calling memcpy() may invoke an architecture-specific implementation. Architectures are free to implement memcpy() however they want and may assume that buffers don't overlap in either direction. So while this happens to work for all current architecture implementations of memcpy(), it's safer not to rely on that and only rely on the known implementation of default_memcpy() for the forwards-overlapping case. Signed-off-by: Julius Werner <jwerner@chromium.org> Change-Id: I7ece4ce9e6622a36612bfade3deb62f351877789 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44691 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
-rw-r--r--payloads/libpayload/libc/memory.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/payloads/libpayload/libc/memory.c b/payloads/libpayload/libc/memory.c
index daa53f1bcb..cc33eab686 100644
--- a/payloads/libpayload/libc/memory.c
+++ b/payloads/libpayload/libc/memory.c
@@ -90,7 +90,7 @@ static void *default_memmove(void *dst, const void *src, size_t n)
ssize_t i;
if (src > dst)
- return memcpy(dst, src, n);
+ return default_memcpy(dst, src, n);
if (!IS_ALIGNED((uintptr_t)dst, sizeof(unsigned long)) ||
!IS_ALIGNED((uintptr_t)src, sizeof(unsigned long))) {