diff options
| author | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2021-04-30 13:47:04 -0600 |
|---|---|---|
| committer | Tim Wawrzynczak <twawrzynczak@chromium.org> | 2021-05-03 16:28:53 +0000 |
| commit | b1623f23c0095a7dce6c874271f977f197f4949e (patch) | |
| tree | d810c99efbcb519ae4c727dab02816719cf611f3 | |
| parent | 93982c3a6ede0bdb8dd0e94597e4de7b09406947 (diff) | |
| download | coreboot-b1623f23c0095a7dce6c874271f977f197f4949e.tar.xz | |
soc/intel/*: Update data types for variables holding PCH_DEVFN_* macros
The usage of `pci_devfn_t` here is misleading, as these intentionally
store the `PCH_DEVFN_*` macros so they can be used across `smm` and
`ramstage` without requiring the device model. Update to `unsigned int`
instead, as `pci_devfn_t` implies the data is an MMCONF-compatible PCI
devfn offset.
Change-Id: Ic8880de984e6eceda4cbe141e118f3a5fdd672a2
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52808
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/soc/intel/alderlake/elog.c | 2 | ||||
| -rw-r--r-- | src/soc/intel/jasperlake/elog.c | 2 | ||||
| -rw-r--r-- | src/soc/intel/skylake/elog.c | 2 | ||||
| -rw-r--r-- | src/soc/intel/tigerlake/elog.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/soc/intel/alderlake/elog.c b/src/soc/intel/alderlake/elog.c index 84765d9b58..7b0fd8779b 100644 --- a/src/soc/intel/alderlake/elog.c +++ b/src/soc/intel/alderlake/elog.c @@ -12,7 +12,7 @@ #include <types.h> struct pme_map { - pci_devfn_t devfn; + unsigned int devfn; unsigned int wake_source; }; diff --git a/src/soc/intel/jasperlake/elog.c b/src/soc/intel/jasperlake/elog.c index 858b3714d4..61b8fb8a6b 100644 --- a/src/soc/intel/jasperlake/elog.c +++ b/src/soc/intel/jasperlake/elog.c @@ -12,7 +12,7 @@ #include <types.h> struct pme_map { - pci_devfn_t devfn; + unsigned int devfn; unsigned int wake_source; }; diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c index c6be670332..1c80517351 100644 --- a/src/soc/intel/skylake/elog.c +++ b/src/soc/intel/skylake/elog.c @@ -26,7 +26,7 @@ static void pch_log_gpio_gpe(u32 gpe0_sts, u32 gpe0_en, int start) } struct pme_status_info { - pci_devfn_t devfn; + unsigned int devfn; uint8_t reg_offset; uint32_t elog_event; }; diff --git a/src/soc/intel/tigerlake/elog.c b/src/soc/intel/tigerlake/elog.c index 0fccf84d5c..93174be88b 100644 --- a/src/soc/intel/tigerlake/elog.c +++ b/src/soc/intel/tigerlake/elog.c @@ -12,7 +12,7 @@ #include <types.h> struct pme_map { - pci_devfn_t devfn; + unsigned int devfn; unsigned int wake_source; }; |