diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2021-04-15 00:07:38 +0200 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2021-04-29 15:31:17 +0000 |
| commit | d6ace2457ec1203d52bb7b294fda397ec1399605 (patch) | |
| tree | a06d4ddc35066c80d3adf6fa3a9e85914e9a88c1 | |
| parent | 6638b11e2083b431ae9c90d9ae5ff23112f4e1bd (diff) | |
| download | coreboot-d6ace2457ec1203d52bb7b294fda397ec1399605.tar.xz | |
mb/google/zork/smihandler: only print warning in mainboard_smi_gpi
zork doesn't configure any GPIO as PAD_SMI. Since mainboard_smi_gpi will
only get called for a GEVENT that will cause a non-SCI SMI, this isn't
expected to be called. For the unexpected and very unlikely case that it
still does get called, put a printk into mainboard_smi_gpi to see what
is happening there.
TEST=none
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I14c67b21a83b334558cdd54ebf700924aa9d0808
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52359
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| -rw-r--r-- | src/mainboard/google/zork/smihandler.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/mainboard/google/zork/smihandler.c b/src/mainboard/google/zork/smihandler.c index 802487b973..3a10dd25f5 100644 --- a/src/mainboard/google/zork/smihandler.c +++ b/src/mainboard/google/zork/smihandler.c @@ -2,6 +2,7 @@ #include <acpi/acpi.h> #include <baseboard/variants.h> +#include <console/console.h> #include <cpu/x86/smm.h> #include <ec/google/chromeec/smm.h> #include <gpio.h> @@ -11,9 +12,10 @@ void mainboard_smi_gpi(u32 gpi_sts) { - if (CONFIG(EC_GOOGLE_CHROMEEC)) - chromeec_smi_process_events(); + printk(BIOS_WARNING, "No GPIO is set up as PAD_SMI, so %s should never end up being " + "called. gpi_status is %x.\n", __func__, gpi_sts); } + void mainboard_smi_sleep(u8 slp_typ) { size_t num_gpios; |