summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Menzel <pmenzel@molgen.mpg.de>2017-03-08 10:51:52 +0100
committerNico Huber <nico.h@gmx.de>2017-03-29 15:43:38 +0200
commitdeb9b03af9aff54a3dee390cbd5ee63b0b6fcc26 (patch)
treea82c52648d50b66f1e659da11c2f5353be060e14
parentd24dbf99029e6c256791e9d5254ac92848c68fa5 (diff)
downloadcoreboot-deb9b03af9aff54a3dee390cbd5ee63b0b6fcc26.tar.xz
cbfstool/ifwitool: Remove unnecessary assignment
Fix the warning below. ``` util/cbfstool/ifwitool.c:551:2: warning: Value stored to 'offset' is never read offset = read_member(data, offset, sizeof(h->fit_tool_version), ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Found-by: scan-build from clang 3.8.1 Change-Id: I6c322a335a371a20561b32e04e7dcc7310dab607 Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de> Reviewed-on: https://review.coreboot.org/18667 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber <nico.h@gmx.de>
-rw-r--r--util/cbfstool/ifwitool.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/util/cbfstool/ifwitool.c b/util/cbfstool/ifwitool.c
index f6ca2a848e..32d09ca6c8 100644
--- a/util/cbfstool/ifwitool.c
+++ b/util/cbfstool/ifwitool.c
@@ -548,8 +548,8 @@ static void bpdt_read_header(void *data, struct bpdt_header *h,
&h->xor_redundant_block);
offset = read_member(data, offset, sizeof(h->ifwi_version),
&h->ifwi_version);
- offset = read_member(data, offset, sizeof(h->fit_tool_version),
- &h->fit_tool_version);
+ read_member(data, offset, sizeof(h->fit_tool_version),
+ &h->fit_tool_version);
bpdt_validate_header(h, name);
bpdt_print_header(h, name);