summaryrefslogtreecommitdiff
path: root/Documentation/contributing/coding_style.md
diff options
context:
space:
mode:
authorAngel Pons <th3fanbus@gmail.com>2021-03-19 15:13:46 +0100
committerPatrick Georgi <pgeorgi@google.com>2021-03-22 11:26:22 +0000
commit88f94a9635cd64aaf6eeb3ed3991dceabcf6387a (patch)
treefef34198fe0464e964e985d4889f9df747bd66b9 /Documentation/contributing/coding_style.md
parentd12d24b03930665be9ed9a16875577a770e6d7db (diff)
downloadcoreboot-88f94a9635cd64aaf6eeb3ed3991dceabcf6387a.tar.xz
lynxpoint/broadwell: Rename LP GPIO config global
Do not use the same name as the non-LP GPIO config. This allows checking at build-time that a mainboard uses the correct GPIO config format. Without this commit, there are no build-time errors when using the wrong format of GPIO config, but there would be undefined behavior at runtime. Tested by trying to build asrock/b85m_pro4 and hp/folio_9480m after toggling the `INTEL_LYNXPOINT_LP` Kconfig option (and trimming down the USB config arrays for asrock/b85m_pro4). In both cases, building failed because the necessary GPIO config global is not defined, as expected. Change-Id: Ib06507ef8179da22bdb27593daf972e788051f3a Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51661 Reviewed-by: Nico Huber <nico.h@gmx.de> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'Documentation/contributing/coding_style.md')
0 files changed, 0 insertions, 0 deletions