diff options
| author | Martin Roth <gaumless@gmail.com> | 2015-06-25 09:36:27 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2015-11-23 18:48:58 +0100 |
| commit | 77c67b3d30d070aa0ddb016d99ce2f1a28cac633 (patch) | |
| tree | 3a6553b3b1d9bcdaff10d5e35b645ffa2b49e016 /Makefile.inc | |
| parent | 845b00ce3344d1483d98cddcf59f317a1b96da64 (diff) | |
| download | coreboot-77c67b3d30d070aa0ddb016d99ce2f1a28cac633.tar.xz | |
IASL: Enable warnings as errors
We've actually got more warnings now than when I first tested IASL
warnings as errors. Because of this, I'm adding it with the option
to have it disabled, in hopes that things won't get any worse as we
work on fixing the IASL warnings that are currently in the codebase.
- Enable IASL warnings as errors
- Disable warnings as errors in mainboards that currently have warnings.
- Print a really obnoxious message on those platforms when they build.
***** WARNING: IASL warnings as errors is disabled! *****
***** Please fix the ASL for this platform. *****
Change-Id: If0da0ac709bd8c0e8e2dbd3a498fe6ecb5500a81
Signed-off-by: Martin Roth <gaumless@gmail.com>
Reviewed-on: http://review.coreboot.org/10663
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Diffstat (limited to 'Makefile.inc')
| -rw-r--r-- | Makefile.inc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/Makefile.inc b/Makefile.inc index 65aa71ca62..53b658b9ce 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -196,7 +196,11 @@ cbfs-files-$(if $(2),$(2),y) += $(call strip_quotes,$(CONFIG_CBFS_PREFIX))/$(1). $(obj)/$(1).aml: $(src)/mainboard/$(MAINBOARDDIR)/$(1).asl $(obj)/config.h @printf " IASL $$(subst $(top)/,,$$(@))\n" $(CC_ramstage) -x assembler-with-cpp -E -MMD -MT $$(@) $$(CPPFLAGS_ramstage) -D__ACPI__ -P -include $(src)/include/kconfig.h -I$(obj) -I$(src) -I$(src)/include -I$(src)/arch/$(ARCHDIR-$(ARCH-ramstage-y))/include -I$(src)/mainboard/$(MAINBOARDDIR) $$< -o $$@ +ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),y) + cd $$(dir $$@); $(IASL) -we -p $$(notdir $$@) $$(notdir $$@) +else cd $$(dir $$@); $(IASL) -p $$(notdir $$@) $$(notdir $$@) +endif endef ####################################################################### @@ -660,6 +664,10 @@ endif mv $@.tmp $@ @printf " CBFSPRINT $(subst $(obj)/,,$(@))\n\n" $(CBFSTOOL) $@ print +ifeq ($(CONFIG_IASL_WARNINGS_ARE_ERRORS),) + @printf "\n***** WARNING: IASL warnings as errors is disabled! *****\n" + @printf "***** Please fix the ASL for this platform. *****\n\n" +endif cbfs-files-$(CONFIG_BOOTSPLASH_IMAGE) += bootsplash.jpg bootsplash.jpg-file := $(call strip_quotes,$(CONFIG_BOOTSPLASH_FILE)) |