Use coreboot build system for libpayload, too.

This change makes building coreboot related projects more unified.

Change-Id: I0f1181e2fffde1e03675523f7dc9eef3119052c3
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/71
Tested-by: build bot (Jenkins)
Reviewed-by: Uwe Hermann <uwe@hermann-uwe.de>

1 files changed, 204 insertions, 111 deletions

diff --git a/payloads/libpayload/Makefile b/payloads/libpayload/Makefile
index 4363590a14..b976baa1d1 100644
--- a/payloads/libpayload/Makefile
+++ b/payloads/libpayload/Makefile
@@ -1,8 +1,10 @@
 ##
-## This file is part of the libpayload project.
+## This file is part of the coreboot project.
 ##
 ## Copyright (C) 2008 Advanced Micro Devices, Inc.
 ## Copyright (C) 2008 Uwe Hermann <uwe@hermann-uwe.de>
+## Copyright (C) 2009-2010 coresystems GmbH
+## Copyright (C) 2011 secunet Security Networks AG
 ##
 ## Redistribution and use in source and binary forms, with or without
 ## modification, are permitted provided that the following conditions
@@ -28,159 +30,250 @@
 ## SUCH DAMAGE.
 ##
 
-export src := $(shell pwd)
-export srctree := $(src)
-export srck := $(src)/util/kconfig
-export obj := $(src)/build
-export objk := $(src)/build/util/kconfig
+ifeq ($(INNER_SCANBUILD),y)
+CC_real:=$(CC)
+endif
+
+$(if $(wildcard .xcompile),,$(eval $(shell bash util/xcompile/xcompile > .xcompile)))
+include .xcompile
+
+ifeq ($(INNER_SCANBUILD),y)
+CC:=$(CC_real)
+HOSTCC:=$(CC_real) --hostcc
+HOSTCXX:=$(CC_real) --hostcxx
+endif
+
+export top := $(CURDIR)
+export src := src
+export srck := $(top)/util/kconfig
+export obj ?= build
+export objutil ?= $(obj)/util
+export objk := $(objutil)/kconfig
 
-export KERNELVERSION      := 0.2.0
-export KCONFIG_AUTOHEADER := $(obj)/include/libpayload-config.h
+
+export KCONFIG_AUTOHEADER := $(obj)/config.h
 export KCONFIG_AUTOCONFIG := $(obj)/auto.conf
 
+# directory containing the toplevel Makefile.inc
+TOPLEVEL := .
+
 CONFIG_SHELL := sh
 KBUILD_DEFCONFIG := configs/defconfig
 UNAME_RELEASE := $(shell uname -r)
-HAVE_DOTCONFIG := $(wildcard .config)
+DOTCONFIG ?= .config
+KCONFIG_CONFIG = $(DOTCONFIG)
+export KCONFIG_CONFIG
+HAVE_DOTCONFIG := $(wildcard $(DOTCONFIG))
 MAKEFLAGS += -rR --no-print-directory
 
 # Make is silent per default, but 'make V=1' will show all compiler calls.
+Q:=@
 ifneq ($(V),1)
-Q := @
+ifneq ($(Q),)
+.SILENT:
+endif
 endif
 
-$(if $(wildcard .xcompile),,$(eval $(shell bash util/xcompile/xcompile > .xcompile)))
-include .xcompile
-
-CC ?= gcc
+CPP:= $(CC) -x assembler-with-cpp -DASSEMBLY -E
 HOSTCC = gcc
 HOSTCXX = g++
-HOSTCFLAGS := -I$(srck) -I$(objk) -pipe
-HOSTCXXFLAGS := -I$(srck) -I$(objk) -pipe
-
-DESTDIR = $(src)/install
+HOSTCFLAGS := -I$(srck) -I$(objk) -g
+HOSTCXXFLAGS := -I$(srck) -I$(objk)
+LIBGCC_FILE_NAME := $(shell test -r `$(CC) -print-libgcc-file-name` && $(CC) -print-libgcc-file-name)
 
 DOXYGEN := doxygen
 DOXYGEN_OUTPUT_DIR := doxygen
 
+all: real-all
+
+# This include must come _before_ the pattern rules below!
+# Order _does_ matter for pattern rules.
+include util/kconfig/Makefile
+
+# Three cases where we don't need fully populated $(obj) lists:
+# 1. when no .config exists
+# 2. when make config (in any flavour) is run
+# 3. when make distclean is run
+# Don't waste time on reading all Makefile.incs in these cases
 ifeq ($(strip $(HAVE_DOTCONFIG)),)
+NOCOMPILE:=1
+endif
+ifneq ($(MAKECMDGOALS),)
+ifneq ($(filter %config distclean,$(MAKECMDGOALS)),)
+NOCOMPILE:=1
+endif
+endif
 
-all: config
+ifeq ($(NOCOMPILE),1)
+include $(TOPLEVEL)/Makefile.inc
+real-all: config
 
 else
 
-include $(src)/.config
+include $(HAVE_DOTCONFIG)
 
-ARCHDIR-$(CONFIG_TARGET_I386)    := i386
-ARCHDIR-$(CONFIG_TARGET_POWERPC) := powerpc
+ifneq ($(INNER_SCANBUILD),y)
+ifeq ($(CONFIG_COMPILER_LLVM_CLANG),y)
+CC:=clang -m32
+HOSTCC:=clang
+endif
+endif
 
-PLATFORM-y += arch/$(ARCHDIR-y)/Makefile.inc
-TARGETS-y :=
+ifeq ($(CONFIG_CCACHE),y)
+CCACHE:=$(word 1,$(wildcard $(addsuffix /ccache,$(subst :, ,$(PATH)))))
+ifeq ($(CCACHE),)
+$(error ccache selected, but not found in PATH)
+endif
+CCACHE:=CCACHE_COMPILERCHECK=content CCACHE_BASEDIR=$(top) $(CCACHE)
+CC := $(CCACHE) $(CC)
+HOSTCC := $(CCACHE) $(HOSTCC)
+HOSTCXX := $(CCACHE) $(HOSTCXX)
+ROMCC := $(CCACHE) $(ROMCC)
+endif
 
-BUILD-y := crypto/Makefile.inc libc/Makefile.inc drivers/Makefile.inc libpci/Makefile.inc
-BUILD-$(CONFIG_TINYCURSES) += curses/Makefile.inc
+strip_quotes = $(subst ",,$(subst \",,$(1)))
 
 # The primary target needs to be here before we include the
 # other files
 
-all: lib
-
-include $(PLATFORM-y) $(BUILD-y)
-
-OBJS     := $(patsubst %,$(obj)/%,$(TARGETS-y))
-INCLUDES := -Iinclude -Iinclude/$(ARCHDIR-y) -I$(obj) -I$(obj)/include
-INCLUDES += -I$(shell $(CC) -print-search-dirs | head -n 1 | cut -d' ' -f2)include
-
-try-run= $(shell set -e; \
-TMP=".$$$$.tmp"; \
-if ($(1)) > /dev/null 2>&1; \
-then echo "$(2)"; \
-else echo "$(3)"; \
-fi; rm -rf "$$TMP")
-
-cc-option= $(call try-run,\
-$(CC) $(1) -S -xc /dev/null -o "$$TMP", $(1), $(2))
-
-STACKPROTECT += $(call cc-option, -fno-stack-protector,)
-
-# TODO: Re-add -Os as soon as we find out why it caused problems.
-CFLAGS := -Wall -Werror $(STACKPROTECT) -nostdinc $(INCLUDES) -ffreestanding -pipe
-
-all: lib
-
-lib: $(obj)/lib/libpayload.a $(obj)/lib/$(ARCHDIR-y)/head.o
+ifeq ($(INNER_SCANBUILD),y)
+CONFIG_SCANBUILD_ENABLE:=
+endif
 
-$(obj)/lib/$(ARCHDIR-y)/head.o: $(obj)/arch/$(ARCHDIR-y)/head.S.o
-	$(Q)printf "  CP      $(subst $(shell pwd)/,,$(@))\n"
-	$(Q)cp $< $@
+ifeq ($(CONFIG_SCANBUILD_ENABLE),y)
+ifneq ($(CONFIG_SCANBUILD_REPORT_LOCATION),)
+CONFIG_SCANBUILD_REPORT_LOCATION:=-o $(CONFIG_SCANBUILD_REPORT_LOCATION)
+endif
+real-all:
+	echo '#!/bin/sh' > .ccwrap
+	echo 'CC="$(CC)"' >> .ccwrap
+	echo 'if [ "$$1" = "--hostcc" ]; then shift; CC="$(HOSTCC)"; fi' >> .ccwrap
+	echo 'if [ "$$1" = "--hostcxx" ]; then shift; CC="$(HOSTCXX)"; fi' >> .ccwrap
+	echo 'eval $$CC $$*' >> .ccwrap
+	chmod +x .ccwrap
+	scan-build $(CONFIG_SCANBUILD_REPORT_LOCATION) -analyze-headers --use-cc=$(top)/.ccwrap --use-c++=$(top)/.ccwrap $(MAKE) INNER_SCANBUILD=y
+else
+real-all: real-target
+endif
 
-$(obj)/lib/libpayload.a: prepare $(OBJS)
-	$(Q)printf "  AR      $(subst $(shell pwd)/,,$(@))\n"
-	$(Q)$(AR) rc $@ $(OBJS)
+# must come rather early
+.SECONDEXPANSION:
+
+$(obj)/config.h:
+	$(MAKE) oldconfig
+
+# Add a new class of source/object files to the build system
+add-class= \
+	$(eval $(1)-srcs:=) \
+	$(eval $(1)-objs:=) \
+	$(eval classes+=$(1))
+
+# Special classes are managed types with special behaviour
+# On parse time, for each entry in variable $(1)-y
+# a handler $(1)-handler is executed with the arguments:
+# * $(1): directory the parser is in
+# * $(2): current entry
+add-special-class= \
+	$(eval $(1):=) \
+	$(eval special-classes+=$(1))
+
+# Clean -y variables, include Makefile.inc
+# Add paths to files in X-y to X-srcs
+# Add subdirs-y to subdirs
+includemakefiles= \
+	$(foreach class,classes subdirs $(classes) $(special-classes), $(eval $(class)-y:=)) \
+	$(eval -include $(1)) \
+	$(foreach class,$(classes-y), $(call add-class,$(class))) \
+	$(foreach class,$(classes), \
+		$(eval $(class)-srcs+= \
+			$$(subst $(top)/,, \
+			$$(abspath $$(addprefix $(dir $(1)),$$($(class)-y)))))) \
+	$(foreach special,$(special-classes), \
+		$(foreach item,$($(special)-y), $(call $(special)-handler,$(dir $(1)),$(item)))) \
+	$(eval subdirs+=$$(subst $(CURDIR)/,,$$(abspath $$(addprefix $(dir $(1)),$$(subdirs-y)))))
+
+# For each path in $(subdirs) call includemakefiles
+# Repeat until subdirs is empty
+evaluate_subdirs= \
+	$(eval cursubdirs:=$(subdirs)) \
+	$(eval subdirs:=) \
+	$(foreach dir,$(cursubdirs), \
+		$(eval $(call includemakefiles,$(dir)/Makefile.inc))) \
+	$(if $(subdirs),$(eval $(call evaluate_subdirs)))
+
+# collect all object files eligible for building
+subdirs:=$(TOPLEVEL)
+$(eval $(call evaluate_subdirs))
+
+src-to-obj=$(addsuffix .$(1).o, $(basename $(addprefix $(obj)/, $($(1)-srcs))))
+$(foreach class,$(classes),$(eval $(class)-objs:=$(call src-to-obj,$(class))))
+
+allsrcs:=$(foreach var, $(addsuffix -srcs,$(classes)), $($(var)))
+allobjs:=$(foreach var, $(addsuffix -objs,$(classes)), $($(var)))
+alldirs:=$(sort $(abspath $(dir $(allobjs))))
+
+# macro to define template macros that are used by use_template macro
+define create_cc_template
+# $1 obj class
+# $2 source suffix (c, S)
+# $3 additional compiler flags
+# $4 additional dependencies
+ifn$(EMPTY)def $(1)-objs_$(2)_template
+de$(EMPTY)fine $(1)-objs_$(2)_template
+$(obj)/$$(1).$(1).o: $$(1).$(2) $(obj)/config.h $(4)
+	@printf "    CC         $$$$(subst $$$$(obj)/,,$$$$(@))\n"
+	$(CC) $(3) -MMD $$$$(CFLAGS) -c -o $$$$@ $$$$<
+en$(EMPTY)def
+end$(EMPTY)if
+endef
+
+filetypes-of-class=$(subst .,,$(sort $(suffix $($(1)-srcs))))
+$(foreach class,$(classes), \
+	$(foreach type,$(call filetypes-of-class,$(class)), \
+		$(eval $(call create_cc_template,$(class),$(type),$($(class)-$(type)-ccopts),$($(class)-$(type)-deps)))))
+
+foreach-src=$(foreach file,$($(1)-srcs),$(eval $(call $(1)-objs_$(subst .,,$(suffix $(file)))_template,$(basename $(file)))))
+$(eval $(foreach class,$(classes),$(call foreach-src,$(class))))
+
+DEPENDENCIES = $(allobjs:.o=.d)
+-include $(DEPENDENCIES)
+
+printall:
+	@$(foreach class,$(classes),echo $(class)-objs:=$($(class)-objs); )
+	@echo alldirs:=$(alldirs)
+	@echo allsrcs=$(allsrcs)
+	@echo DEPENDENCIES=$(DEPENDENCIES)
+	@echo LIBGCC_FILE_NAME=$(LIBGCC_FILE_NAME)
+	@$(foreach class,$(special-classes),echo $(class):='$($(class))'; )
 
 endif
 
-install: lib
-	$(Q)printf "  INSTALL $(DESTDIR)/libpayload/lib\n"
-	$(Q)install -m 755 -d $(DESTDIR)/libpayload/lib
-	$(Q)install -m 644 $(obj)/lib/libpayload.a $(DESTDIR)/libpayload/lib/
-	$(Q)install -m 644 lib/libpayload.ldscript $(DESTDIR)/libpayload/lib/
-	$(Q)install -m 755 -d $(DESTDIR)/libpayload/lib/$(ARCHDIR-y)
-	$(Q)install -m 644 $(obj)/lib/$(ARCHDIR-y)/head.o $(DESTDIR)/libpayload/lib/$(ARCHDIR-y)
-	$(Q)printf "  INSTALL $(DESTDIR)/libpayload/include\n"
-	$(Q)install -m 755 -d $(DESTDIR)/libpayload/include
-	$(Q)for file in `find include -name *.h -type f`; do \
-		install -m 755 -d $(DESTDIR)/libpayload/`dirname $$file`; \
-		install -m 644 $$file $(DESTDIR)/libpayload/$$file; \
-	done
-	$(Q)install -m 644 $(KCONFIG_AUTOHEADER) $(DESTDIR)/libpayload/include
-	$(Q)printf "  INSTALL $(DESTDIR)/libpayload/bin\n"
-	$(Q)install -m 755 -d $(DESTDIR)/libpayload/bin
-	$(Q)install -m 755 bin/lpgcc $(DESTDIR)/libpayload/bin
-	$(Q)install -m 755 bin/lpas $(DESTDIR)/libpayload/bin
-	$(Q)install -m 644 bin/lp.functions $(DESTDIR)/libpayload/bin
-	$(Q)install -m 644 .config $(DESTDIR)/libpayload/libpayload.config
-
-prepare:
-	$(Q)mkdir -p $(obj)/util/kconfig/lxdialog
-	$(Q)mkdir -p $(obj)/crypto $(obj)/curses $(obj)/drivers/video
-	$(Q)mkdir -p $(obj)/drivers/usb
-	$(Q)mkdir -p $(obj)/arch/$(ARCHDIR-y) $(obj)/lib/$(ARCHDIR-y) $(obj)/libc $(obj)/libpci
-	$(Q)mkdir -p $(obj)/lib/$(ARCHDIR-y)
-	$(Q)mkdir -p $(obj)/include
+$(shell mkdir -p $(obj) $(objutil)/kconfig/lxdialog $(additional-dirs) $(alldirs))
+
+cscope:
+	cscope -bR
 
 doxy: doxygen
 doxygen:
-	$(Q)$(DOXYGEN) Doxyfile
+	$(DOXYGEN) Doxyfile
 
 doxyclean: doxygen-clean
 doxygen-clean:
-	$(Q)rm -rf $(DOXYGEN_OUTPUT_DIR)
-
-clean: doxygen-clean
-	$(Q)rm -rf $(obj)/crypto $(obj)/curses $(obj)/drivers
-	$(Q)rm -rf $(obj)/i386 $(obj)/powerpc $(obj)/lib $(obj)/libc
-
-distclean: clean
-	$(Q)rm -rf build # should be $(obj) ?
-	$(Q)rm -f .config .config.old .xcompile ..config.tmp .kconfig.d .tmpconfig*
-
-# This include must come _before_ the pattern rules below!
-# Order _does_ matter for pattern rules.
-include util/kconfig/Makefile
-
-ifeq ($(strip $(HAVE_DOTCONFIG)),)
-else
+	rm -rf $(DOXYGEN_OUTPUT_DIR)
 
-$(obj)/%.o: $(src)/%.c
-	$(Q)printf "  CC      $(subst $(shell pwd)/,,$(@))\n"
-	$(Q)$(CC) -m32 $(CFLAGS) -c -o $@ $<
+clean-for-update: doxygen-clean clean-for-update-target
+	rm -f $(allobjs) .xcompile
+	rm -f $(DEPENDENCIES)
+	rmdir -p $(alldirs) 2>/dev/null >/dev/null || true
 
-$(obj)/%.S.o: $(src)/%.S
-	$(Q)printf "  CC      $(subst $(shell pwd)/,,$(@))\n"
-	$(Q)$(CC) -m32 $(CFLAGS) -c -o $@ $<
+clean: clean-for-update clean-target
+	rm -f .ccwrap
 
-endif
+clean-cscope:
+	rm -f cscope.out
 
-.PHONY: $(PHONY) prepare install clean distclean doxygen doxy
+distclean: clean-cscope
+	rm -rf $(obj)
+	rm -f .config .config.old ..config.tmp .kconfig.d .tmpconfig* .ccwrap .xcompile
 
+.PHONY: $(PHONY) clean clean-cscope cscope distclean doxygen doxy .xcompile