summaryrefslogtreecommitdiff
path: root/payloads/libpayload/curses/pdcurses-backend
diff options
context:
space:
mode:
authorPaul Menzel <paulepanter@users.sourceforge.net>2013-03-27 09:50:30 +0100
committerStefan Reinauer <stefan.reinauer@coreboot.org>2013-04-01 23:24:38 +0200
commitbab0a0b577ba8cc28aa1e2b2e9ec65fb98edced1 (patch)
treeadf1149d2e0826780657f483193d612cd8330b82 /payloads/libpayload/curses/pdcurses-backend
parentaf3158c0cfd6034bbdc42a0488382c4be1a7a388 (diff)
downloadcoreboot-bab0a0b577ba8cc28aa1e2b2e9ec65fb98edced1.tar.xz
PDCurses: pdcscrn.c: Use `#ifdef` instead of `#if CONFIG_SPEAKER`
Building libpayload with the PDCurses backend the following warning is shown. /src/coreboot/payloads/libpayload(master) $ make clean /src/coreboot/payloads/libpayload(master) $ make […] CC curses/pdcurses-backend/pdcscrn.libcurses.o curses/pdcurses-backend/pdcscrn.c: In function 'PDC_scr_open': curses/pdcurses-backend/pdcscrn.c:75:5: warning: "CONFIG_SPEAKER" is not defined [-Wundef] […] The GCC documentation states [1] In some contexts this shortcut is undesirable. The -Wundef option causes GCC to warn whenever it encounters an identifier which is not a macro in an ‘#if’. and therefore use `#ifdef` [2] to silence this warning. No functional change is done, as `CONFIG_SPEAKER` is assigned the value `Y` when defined. There was some discussion going on the list [3], but my points in there turned out to be incorrect. [1] http://gcc.gnu.org/onlinedocs/cpp/If.html [2] http://gcc.gnu.org/onlinedocs/cpp/Ifdef.html [3] http://www.coreboot.org/pipermail/coreboot/2013-March/075561.html Change-Id: I8e9c9b5d01985b21ad05018986d614cf9bf2b439 Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-on: http://review.coreboot.org/2934 Reviewed-by: Nico Huber <nico.huber@secunet.com> Tested-by: build bot (Jenkins)
Diffstat (limited to 'payloads/libpayload/curses/pdcurses-backend')
-rw-r--r--payloads/libpayload/curses/pdcurses-backend/pdcscrn.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c b/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
index d3f1849b89..e741b15d09 100644
--- a/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
+++ b/payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
@@ -72,7 +72,7 @@ int PDC_scr_open(int argc, char **argv)
SP->lines = PDC_get_rows();
SP->cols = PDC_get_columns();
-#if CONFIG_SPEAKER
+#ifdef CONFIG_SPEAKER
SP->audible = TRUE;
#endif