diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2014-03-28 23:46:45 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2014-04-01 11:36:00 +0200 |
| commit | deb2cb27e9bade18c4d186899edfaeabfc1131bd (patch) | |
| tree | 3827d61ee049cb0f2d5edc6951210d112b5378f7 /src/Kconfig | |
| parent | 0ec3f493a332a7e779600406732141573fafd526 (diff) | |
| download | coreboot-deb2cb27e9bade18c4d186899edfaeabfc1131bd.tar.xz | |
Static CBMEM / CAR: Flag boards with BROKEN_CAR_MIGRATE
Use of CAR_GLOBAL is not safe after CAR is torn down, unless the
board properly implements EARLY_CBMEM_INIT.
Flag vulnerable boards that only do cbmem_recovery() in romstage on S3
resume and implementation with Intel FSP that invalidates cache before
we have a chance to copy the contents.
Change-Id: Iecd10dee9b73ab3f1f66826950fa0945675ff39f
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/5419
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@google.com>
Diffstat (limited to 'src/Kconfig')
| -rw-r--r-- | src/Kconfig | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/src/Kconfig b/src/Kconfig index 531a8c860b..fe7dc9b017 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -170,6 +170,15 @@ config EARLY_CBMEM_INIT some, for instance, execution timestamps. It needs support in romstage.c and should be enabled by the board's Kconfig. +config BROKEN_CAR_MIGRATE + bool + default y if !EARLY_CBMEM_INIT && HAVE_ACPI_RESUME + default n + help + Many boards use CAR_GLOBAL but have no EARLY_CBMEM_INIT and + manage CAR migration on S3 resume path only. Couple boards use + CAR_GLOBAL and never do CAR migration. + config DYNAMIC_CBMEM bool "The CBMEM space is dynamically grown." default n |