diff options
author | Martin Roth <martinroth@google.com> | 2017-01-26 15:37:10 -0700 |
---|---|---|
committer | Martin Roth <martinroth@google.com> | 2017-02-20 04:40:01 +0100 |
commit | f797a1ac6a72a571ba76bff8b7c451cc090778a9 (patch) | |
tree | 25e8b23d1be76b586467eb0c71e9492e09de476b /src/arch/riscv/include | |
parent | 98641b92e7840f42cef36a3a44b3118d25c5b2f7 (diff) | |
download | coreboot-f797a1ac6a72a571ba76bff8b7c451cc090778a9.tar.xz |
riscv: Suppress invalid coverity errors
Coverity is detecting 'sp' as a variable which has not been initialized.
This is obviously not correct, so this patch *TRIES* to mark it as false
I'm not positive that this will work because the annotation needs to go
on the line above the error, but this error is inside of a # define.
Does the whole #define count as one line? Can it go on the line
above the #define in the .h file? Does it have to precede every line
where the #define is used? The documentation doesn't make this clear.
Should suppress coverity issues: 1368525 & 1368527
uninit_use: Using uninitialized value sp.
Change-Id: Ibae5e206c4ff47991ea8a11b6b59972b24b71796
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/18247
Tested-by: build bot (Jenkins)
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Diffstat (limited to 'src/arch/riscv/include')
-rw-r--r-- | src/arch/riscv/include/mcall.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/arch/riscv/include/mcall.h b/src/arch/riscv/include/mcall.h index 1e74ed345d..cdd9bd38eb 100644 --- a/src/arch/riscv/include/mcall.h +++ b/src/arch/riscv/include/mcall.h @@ -70,6 +70,7 @@ typedef struct { } hls_t; #define MACHINE_STACK_TOP() ({ \ + /* coverity[uninit_use] : FALSE */ \ register uintptr_t sp asm ("sp"); \ (void*)((sp + RISCV_PGSIZE) & -RISCV_PGSIZE); }) |