diff options
author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-16 13:41:11 -0700 |
---|---|---|
committer | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-17 03:17:39 +0100 |
commit | 024b13d07c6dcef7acefc3b69c16c46be431fb82 (patch) | |
tree | b31fb158c61e7c5609a5f16c39624363aa2048d1 /src/arch/x86/acpi.c | |
parent | 9c7c6f7213decfc0d0fee4bbc911a291ee93bcdb (diff) | |
download | coreboot-024b13d07c6dcef7acefc3b69c16c46be431fb82.tar.xz |
arch/x86: Fix space issues detected by checkpatch
Fix the following errors and warnings detected by checkpatch.pl:
ERROR: space required before the open parenthesis '('
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
ERROR: space prohibited after that open square bracket '['
ERROR: space required after that ',' (ctx:VxV)
ERROR: space prohibited before that ',' (ctx:WxW)
ERROR: space required after that ';' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:ExV)
ERROR: spaces required around that ':' (ctx:VxW)
ERROR: spaces required around that ':' (ctx:WxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '+=' (ctx:VxV)
ERROR: spaces required around that '<=' (ctx:WxV)
ERROR: spaces required around that '||' (ctx:VxW)
ERROR: space prohibited before that '++' (ctx:WxO)
ERROR: need consistent spacing around '+' (ctx:WxV)
ERROR: spaces required around that '<' (ctx:WxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: need consistent spacing around '>>' (ctx:WxV)
ERROR: "(foo*)" should be "(foo *)"
ERROR: "foo* bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: code indent should use tabs where possible
WARNING: space prohibited between function name and open parenthesis '('
WARNING: unnecessary whitespace before a quoted newline
WARNING: please, no spaces at the start of a line
WARNING: please, no space before tabs
WARNING: Unnecessary space before function pointer arguments
TEST=Build and run on Galileo Gen2
Change-Id: I2d7e1a329c6b2e8ca9633a97b595566544d7fd33
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18862
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/arch/x86/acpi.c')
-rw-r--r-- | src/arch/x86/acpi.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index 4109ec4fae..eeab3b37e0 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -272,7 +272,7 @@ static void *get_tcpa_log(u32 *size) } printk(BIOS_DEBUG, "TCPA log created at %p\n", lasa); - memset (lasa, 0, tcpa_default_log_len); + memset(lasa, 0, tcpa_default_log_len); *size = tcpa_default_log_len; return lasa; @@ -420,7 +420,7 @@ void acpi_create_srat(acpi_srat_t *srat, } void acpi_create_dmar(acpi_dmar_t *dmar, enum dmar_flags flags, - unsigned long (*acpi_fill_dmar) (unsigned long)) + unsigned long (*acpi_fill_dmar)(unsigned long)) { acpi_header_t *header = &(dmar->header); unsigned long current = (unsigned long)dmar + sizeof(acpi_dmar_t); @@ -580,7 +580,7 @@ void acpi_create_hpet(acpi_hpet_t *hpet) addr->addrl = CONFIG_HPET_ADDRESS & 0xffffffff; addr->addrh = ((unsigned long long)CONFIG_HPET_ADDRESS) >> 32; - hpet->id = *(unsigned int*)CONFIG_HPET_ADDRESS; + hpet->id = *(unsigned int *)CONFIG_HPET_ADDRESS; hpet->number = 0; hpet->min_tick = CONFIG_HPET_MIN_TICKS; @@ -613,7 +613,7 @@ void acpi_create_vfct(struct device *device, } void acpi_create_ivrs(acpi_ivrs_t *ivrs, - unsigned long (*acpi_fill_ivrs)(acpi_ivrs_t* ivrs_struct, unsigned long current)) + unsigned long (*acpi_fill_ivrs)(acpi_ivrs_t *ivrs_struct, unsigned long current)) { acpi_header_t *header = &(ivrs->header); unsigned long current = (unsigned long)ivrs + sizeof(acpi_ivrs_t); @@ -786,7 +786,7 @@ unsigned long acpi_create_hest_error_source(acpi_hest_t *hest, acpi_hest_esd_t * printk(BIOS_DEBUG, "Invalid type of Error Source."); break; } - hest->error_source_count ++; + hest->error_source_count++; memcpy(pos, data, data_len); len += data_len; @@ -817,7 +817,7 @@ void acpi_write_hest(acpi_hest_t *hest, } #if IS_ENABLED(CONFIG_COMMON_FADT) -void acpi_create_fadt(acpi_fadt_t *fadt,acpi_facs_t *facs, void *dsdt) +void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) { acpi_header_t *header = &(fadt->header); @@ -1015,8 +1015,8 @@ unsigned long write_acpi_tables(unsigned long start) madt = (acpi_madt_t *) current; acpi_create_madt(madt); if (madt->header.length > sizeof(acpi_madt_t)) { - current+=madt->header.length; - acpi_add_table(rsdp,madt); + current += madt->header.length; + acpi_add_table(rsdp, madt); } current = acpi_align_current(current); |