diff options
| author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-16 13:41:11 -0700 |
|---|---|---|
| committer | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-17 03:17:39 +0100 |
| commit | 024b13d07c6dcef7acefc3b69c16c46be431fb82 (patch) | |
| tree | b31fb158c61e7c5609a5f16c39624363aa2048d1 /src/arch/x86/boot.c | |
| parent | 9c7c6f7213decfc0d0fee4bbc911a291ee93bcdb (diff) | |
| download | coreboot-024b13d07c6dcef7acefc3b69c16c46be431fb82.tar.xz | |
arch/x86: Fix space issues detected by checkpatch
Fix the following errors and warnings detected by checkpatch.pl:
ERROR: space required before the open parenthesis '('
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
ERROR: space prohibited after that open square bracket '['
ERROR: space required after that ',' (ctx:VxV)
ERROR: space prohibited before that ',' (ctx:WxW)
ERROR: space required after that ';' (ctx:VxV)
ERROR: spaces required around that ':' (ctx:ExV)
ERROR: spaces required around that ':' (ctx:VxW)
ERROR: spaces required around that ':' (ctx:WxV)
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '+=' (ctx:VxV)
ERROR: spaces required around that '<=' (ctx:WxV)
ERROR: spaces required around that '||' (ctx:VxW)
ERROR: space prohibited before that '++' (ctx:WxO)
ERROR: need consistent spacing around '+' (ctx:WxV)
ERROR: spaces required around that '<' (ctx:WxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: need consistent spacing around '>>' (ctx:WxV)
ERROR: "(foo*)" should be "(foo *)"
ERROR: "foo* bar" should be "foo *bar"
ERROR: "foo * bar" should be "foo *bar"
ERROR: code indent should use tabs where possible
WARNING: space prohibited between function name and open parenthesis '('
WARNING: unnecessary whitespace before a quoted newline
WARNING: please, no spaces at the start of a line
WARNING: please, no space before tabs
WARNING: Unnecessary space before function pointer arguments
TEST=Build and run on Galileo Gen2
Change-Id: I2d7e1a329c6b2e8ca9633a97b595566544d7fd33
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18862
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/arch/x86/boot.c')
| -rw-r--r-- | src/arch/x86/boot.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/src/arch/x86/boot.c b/src/arch/x86/boot.c index ba78c4e308..b9e6ee930f 100644 --- a/src/arch/x86/boot.c +++ b/src/arch/x86/boot.c @@ -24,13 +24,13 @@ static void jmp_payload_no_bounce_buffer(void *entry) { /* Jump to kernel */ __asm__ __volatile__( - " cld \n\t" + " cld\n\t" /* Now jump to the loaded image */ " call *%0\n\t" /* The loaded image returned? */ - " cli \n\t" - " cld \n\t" + " cli\n\t" + " cld\n\t" :: "r" (entry) @@ -51,7 +51,7 @@ static void jmp_payload(void *entry, unsigned long buffer, unsigned long size) /* Jump to kernel */ __asm__ __volatile__( - " cld \n\t" + " cld\n\t" #ifdef __x86_64__ /* switch back to 32-bit mode */ " push %4\n\t" @@ -138,7 +138,7 @@ static void jmp_payload(void *entry, unsigned long buffer, unsigned long size) " movl $1f, %%eax\n\t" " addl 20(%%esp), %%eax\n\t" " jmp *%%eax\n\t" - "1: \n\t" + "1:\n\t" /* Copy the coreboot bounce buffer over coreboot */ /* Move ``longs'' the coreboot size is 4 byte aligned */ @@ -154,8 +154,8 @@ static void jmp_payload(void *entry, unsigned long buffer, unsigned long size) " call *4(%%esp)\n\t" /* The loaded image returned? */ - " cli \n\t" - " cld \n\t" + " cli\n\t" + " cld\n\t" /* Copy the saved copy of coreboot where coreboot runs */ /* Move ``longs'' the coreboot size is 4 byte aligned */ @@ -173,7 +173,7 @@ static void jmp_payload(void *entry, unsigned long buffer, unsigned long size) " movl $1f, %%eax\n\t" " subl 20(%%esp), %%eax\n\t" " jmp *%%eax\n\t" - "1: \n\t" + "1:\n\t" /* Drop the parameters I was passed */ " addl $24, %%esp\n\t" |