summaryrefslogtreecommitdiff
path: root/src/arch/x86/include
diff options
context:
space:
mode:
authorMartin Roth <gaumless@gmail.com>2015-01-22 19:10:10 -0700
committerMartin Roth <gaumless@gmail.com>2015-02-09 17:44:02 +0100
commitad4fa21705e66a0f350597da043c845aa79bce99 (patch)
tree8da8cbd37972b0374f003d94806caed6931f29d0 /src/arch/x86/include
parentcd02ef19e5b26abf2b35a47b31f31e0cde3a9820 (diff)
downloadcoreboot-ad4fa21705e66a0f350597da043c845aa79bce99.tar.xz
Get rid of .car.global_data warnings for GCC build
The "used" attribute was added in commit 27cf2472 which caused these warnings to start appearing when using the standard coreboot GCC toolchain: {standard input}: Assembler messages: {standard input}:96: Warning: ignoring changed section type for .car.global_data {standard input}:96: Warning: ignoring changed section attributes for .car.global_data The # at the end of the section name causes the assembler to ignore everything following the name. I verified that the resulting binaries are the same with and without the #. Change-Id: Iaac8042533842ed887f33895f083b613a18f496a Signed-off-by: Martin Roth <gaumless@gmail.com> Reviewed-on: http://review.coreboot.org/8301 Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@google.com>
Diffstat (limited to 'src/arch/x86/include')
-rw-r--r--src/arch/x86/include/arch/early_variables.h4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/arch/x86/include/arch/early_variables.h b/src/arch/x86/include/arch/early_variables.h
index 2d5ae859ff..5394af342a 100644
--- a/src/arch/x86/include/arch/early_variables.h
+++ b/src/arch/x86/include/arch/early_variables.h
@@ -23,8 +23,12 @@
#ifdef __PRE_RAM__
asm(".section .car.global_data,\"w\",@nobits");
asm(".previous");
+#ifdef __clang__
#define CAR_GLOBAL __attribute__((used,section(".car.global_data")))
#else
+#define CAR_GLOBAL __attribute__((used,section(".car.global_data#")))
+#endif /* __clang__ */
+#else
#define CAR_GLOBAL
#endif