diff options
| author | Ronald G. Minnich <rminnich@gmail.com> | 2012-07-02 09:41:10 -0700 |
|---|---|---|
| committer | Sven Schnelle <svens@stackframe.org> | 2012-07-05 23:01:42 +0200 |
| commit | 97de28da8af758b85c644b3dc151aeb743e13412 (patch) | |
| tree | 11823473dd850f8cdaf0be2b97cef64ddfb30d8f /src/arch/x86/include | |
| parent | 63539bb9d7fe9ae55a364cadfcbd79ecb98a9412 (diff) | |
| download | coreboot-97de28da8af758b85c644b3dc151aeb743e13412.tar.xz | |
PCI Type2 config must die
PCI Type 2 config was a strange and never-used config mechanism.
It is unlikely that in the 13 years of coreboot's existence that
type 2 was ever used; it just made life complicated for everyone.
It lived long enough in coreboot to be replaced by mmioconf.
Prior to making the device tree visible in romstage we want to
get rid of type2.
Delete two files we don't need any more (yay!).
Replace two functions with one: pci_config_default, which returns
a pointer to the default config method. At some future time this
may change to mmio but for now it is old type1 style.
Change-Id: Icc4ccf379a89bfca8be43f305b68ab45d88bf0ab
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Reviewed-on: http://review.coreboot.org/1159
Tested-by: build bot (Jenkins)
Reviewed-by: Sven Schnelle <svens@stackframe.org>
Diffstat (limited to 'src/arch/x86/include')
| -rw-r--r-- | src/arch/x86/include/arch/pci_ops.h | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/arch/x86/include/arch/pci_ops.h b/src/arch/x86/include/arch/pci_ops.h index 955ccd34d8..eca939045f 100644 --- a/src/arch/x86/include/arch/pci_ops.h +++ b/src/arch/x86/include/arch/pci_ops.h @@ -2,12 +2,18 @@ #define ARCH_I386_PCI_OPS_H extern const struct pci_bus_operations pci_cf8_conf1; -extern const struct pci_bus_operations pci_cf8_conf2; #if CONFIG_MMCONF_SUPPORT extern const struct pci_bus_operations pci_ops_mmconf; #endif -void pci_set_method(device_t dev); +static inline const struct pci_bus_operations *pci_config_default(void) +{ + return &pci_cf8_conf1; +} +static inline void pci_set_method(device_t dev) +{ + dev->ops->ops_pci_bus = pci_config_default(); +} #endif /* ARCH_I386_PCI_OPS_H */ |