diff options
| author | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-16 16:01:40 -0700 |
|---|---|---|
| committer | Lee Leahy <leroy.p.leahy@intel.com> | 2017-03-20 16:36:24 +0100 |
| commit | 0b5678f21f17024b4f7f6bd67d0d382481751d86 (patch) | |
| tree | d43ad8a4055b89ddea09ab797bd88df857713956 /src/arch/x86/mpspec.c | |
| parent | 41dded3548327d2cb6bd8845e78b94e51207f8f6 (diff) | |
| download | coreboot-0b5678f21f17024b4f7f6bd67d0d382481751d86.tar.xz | |
arch/x86: Fix most of remaining issues detected by checkpatch
Fix the following errors and warnings detected by checkpatch.pl:
ERROR: do not use assignment in if condition
ERROR: trailing statements should be on next line
ERROR: Macros with complex values should be enclosed in parentheses
ERROR: switch and case should be at the same indent
WARNING: char * array declaration might be better as static const
WARNING: else is not generally useful after a break or return
WARNING: storage class should be at the beginning of the declaration
WARNING: void function return statements are not generally useful
WARNING: break is not useful after a goto or return
WARNING: Single statement macros should not use a do {} while (0) loop
WARNING: sizeof *t should be sizeof(*t)
WARNING: Comparisons should place the constant on the right side of the test
TEST=Build and run on Galileo Gen2
Change-Id: I39d49790c5eaeedec5051e1fab0b1279275f6e7f
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18865
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
Diffstat (limited to 'src/arch/x86/mpspec.c')
| -rw-r--r-- | src/arch/x86/mpspec.c | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c index ab0514b347..d41abaff5a 100644 --- a/src/arch/x86/mpspec.c +++ b/src/arch/x86/mpspec.c @@ -481,8 +481,10 @@ void mptable_write_buses(struct mp_config_table *mc, int *max_pci_bus, char buses[256]; struct device *dev; - if (!max_pci_bus) max_pci_bus = &dummy; - if (!isa_bus) isa_bus = &dummy; + if (!max_pci_bus) + max_pci_bus = &dummy; + if (!isa_bus) + isa_bus = &dummy; *max_pci_bus = 0; highest = 0; @@ -497,7 +499,8 @@ void mptable_write_buses(struct mp_config_table *mc, int *max_pci_bus, return; } buses[bus->secondary] = 1; - if (highest < bus->secondary) highest = bus->secondary; + if (highest < bus->secondary) + highest = bus->secondary; } } for (i = 0; i <= highest; i++) { @@ -545,7 +548,8 @@ unsigned long __attribute__((weak)) write_smp_table(unsigned long addr) if (dev->path.type != DEVICE_PATH_IOAPIC) continue; - if (!(ioapic_config = dev->chip_info)) { + ioapic_config = dev->chip_info; + if (!ioapic_config) { printk(BIOS_ERR, "%s has no config, ignoring\n", dev_path(dev)); continue; |