summaryrefslogtreecommitdiff
path: root/src/arch/x86
diff options
context:
space:
mode:
authorChristian Walter <christian.walter@9elements.com>2019-12-18 15:07:59 +0100
committerNico Huber <nico.h@gmx.de>2020-03-23 16:54:58 +0000
commitbe3979c873d23cb0543e635bba59bd85ab67fed0 (patch)
treec8a1064696607573eebd0b03c411a8aa090f015c /src/arch/x86
parent09eb8d0c9b3b9e7b765520114d148a19926ff886 (diff)
downloadcoreboot-be3979c873d23cb0543e635bba59bd85ab67fed0.tar.xz
acpi: Change Processor ACPI Name (Intel only)
The ACPI Spec 2.0 states, that Processor declarations should be made within the ACPI namespace \_SB and not \_PR anymore. \_PR is deprecated and is removed here for Intel CPUs only. Tested on: * X11SSH (Kabylake) * CFL Platform * Asus P8Z77-V LX2 and Windows 10 FWTS does not return FAIL anymore on ACPI tests Tested-by: Angel Pons <th3fanbus@gmail.com> Change-Id: Ib101ed718f90f9056d2ecbc31b13b749ed1fc438 Signed-off-by: Christian Walter <christian.walter@9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/37814 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/arch/x86')
-rw-r--r--src/arch/x86/Kconfig4
-rw-r--r--src/arch/x86/acpigen.c4
2 files changed, 4 insertions, 4 deletions
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index 810a5bbaab..a4e5314ab5 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -254,11 +254,11 @@ config ACPI_HAVE_PCAT_8259
config ACPI_CPU_STRING
string
- default "\\_PR.CP%02d"
+ default "\\_SB.CP%02d"
depends on HAVE_ACPI_TABLES
help
Sets the ACPI name string in the processor scope as written by
- the acpigen function. Default is \_PR.CPxx. Note that you need
+ the acpigen function. Default is \_SB.CPxx. Note that you need
the \ escape character in the string.
config COLLECT_TIMESTAMPS_NO_TSC
diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index a599b0ecdb..26fe08fa87 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -340,7 +340,7 @@ void acpigen_write_scope(const char *name)
void acpigen_write_processor(u8 cpuindex, u32 pblock_addr, u8 pblock_len)
{
/*
- Processor (\_PR.CPcpuindex, cpuindex, pblock_addr, pblock_len)
+ Processor (\_SB.CPcpuindex, cpuindex, pblock_addr, pblock_len)
{
*/
char pscope[16];
@@ -376,7 +376,7 @@ void acpigen_write_processor_cnot(const unsigned int number_of_cores)
{
int core_id;
- acpigen_write_method("\\_PR.CNOT", 1);
+ acpigen_write_method("\\_SB.CNOT", 1);
for (core_id = 0; core_id < number_of_cores; core_id++) {
char buffer[DEVICE_PATH_MAX];
snprintf(buffer, sizeof(buffer), CONFIG_ACPI_CPU_STRING,