diff options
| author | Patrick Georgi <patrick@georgi-clan.de> | 2013-01-23 13:45:23 +0100 |
|---|---|---|
| committer | Patrick Georgi <patrick@georgi-clan.de> | 2013-01-27 12:21:41 +0100 |
| commit | d1de45e095c53887fa30ebaf6807846d0ef470cd (patch) | |
| tree | b9088ec2eaea155291cda286b5a58c6bbf17e719 /src/arch/x86 | |
| parent | dfff8a163164d28f81ee9d057fb49c8ed3204c6a (diff) | |
| download | coreboot-d1de45e095c53887fa30ebaf6807846d0ef470cd.tar.xz | |
ioapic: Factor out counting code to `ioapic_interrupt_count`
No need to keep duplicate variants of counting ioapic interrupts.
Change-Id: I512860297309c46e05cc5379bf61479878817b1e
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Reviewed-on: http://review.coreboot.org/2185
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/arch/x86')
| -rw-r--r-- | src/arch/x86/lib/ioapic.c | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/src/arch/x86/lib/ioapic.c b/src/arch/x86/lib/ioapic.c index e05d80c7a6..fc5e3072d2 100644 --- a/src/arch/x86/lib/ioapic.c +++ b/src/arch/x86/lib/ioapic.c @@ -34,15 +34,10 @@ static void io_apic_write(u32 ioapic_base, u32 reg, u32 value) write32(ioapic_base + 0x10, value); } -void clear_ioapic(u32 ioapic_base) +static int ioapic_interrupt_count(int ioapic_base) { - u32 low, high; - u32 i, ioapic_interrupts; - - printk(BIOS_DEBUG, "IOAPIC: Clearing IOAPIC at 0x%08x\n", ioapic_base); - /* Read the available number of interrupts. */ - ioapic_interrupts = (io_apic_read(ioapic_base, 0x01) >> 16) & 0xff; + int ioapic_interrupts = (io_apic_read(ioapic_base, 0x01) >> 16) & 0xff; if (ioapic_interrupts == 0xff) ioapic_interrupts = 23; ioapic_interrupts += 1; /* Bits 23-16 specify the maximum redirection @@ -50,6 +45,18 @@ void clear_ioapic(u32 ioapic_base) minus 1. */ printk(BIOS_DEBUG, "IOAPIC: %d interrupts\n", ioapic_interrupts); + return ioapic_interrupts; +} + +void clear_ioapic(u32 ioapic_base) +{ + u32 low, high; + u32 i, ioapic_interrupts; + + printk(BIOS_DEBUG, "IOAPIC: Clearing IOAPIC at 0x%08x\n", ioapic_base); + + ioapic_interrupts = ioapic_interrupt_count(ioapic_base); + low = DISABLED; high = NONE; @@ -86,14 +93,7 @@ void setup_ioapic(u32 ioapic_base, u8 ioapic_id) (ioapic_id << 24)); } - /* Read the available number of interrupts. */ - ioapic_interrupts = (io_apic_read(ioapic_base, 0x01) >> 16) & 0xff; - if (ioapic_interrupts == 0xff) - ioapic_interrupts = 23; - ioapic_interrupts += 1; /* Bits 23-16 specify the maximum redirection - entry, which is the number of interrupts - minus 1. */ - printk(BIOS_DEBUG, "IOAPIC: %d interrupts\n", ioapic_interrupts); + ioapic_interrupts = ioapic_interrupt_count(ioapic_base); #if CONFIG_IOAPIC_INTERRUPTS_ON_FSB /* |