diff options
| author | Alexandru Gagniuc <mr.nuke.me@gmail.com> | 2015-10-02 12:42:26 -0700 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2016-01-30 03:11:12 +0100 |
| commit | f8e491339f685bc43a0b8812f9f00a2918ce7611 (patch) | |
| tree | 8858032194de897e01d3a729e5b887fbb373da4a /src/arch | |
| parent | 3141eac9007634710d9e307170e821f805204683 (diff) | |
| download | coreboot-f8e491339f685bc43a0b8812f9f00a2918ce7611.tar.xz | |
arch/x86: Rename bootblock.S to bootblock_romcc.S
bootblock.S was used strictly for setting up the system so that the
assembly generated by ROMCC could be executed. Since the
infrastructure now exists to run a bootblock wihtout ROMCC, rename
this file accordingly. this is done to prevent any future confusion.
Change-Id: Icbf5804b66b9517f9ceb352bed86978dcf92228f
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-on: https://review.coreboot.org/11784
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/arch')
| -rw-r--r-- | src/arch/x86/Makefile.inc | 10 | ||||
| -rw-r--r-- | src/arch/x86/bootblock_romcc.S (renamed from src/arch/x86/bootblock.S) | 17 |
2 files changed, 20 insertions, 7 deletions
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 82b8ae36f9..2942cae3fb 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -107,9 +107,6 @@ bootblock-y += memcpy.c bootblock-y += memset.c bootblock-y += mmap_boot.c -# Add the assembly file that pulls in the rest of the dependencies in -# the right order. Make sure the auto generated bootblock.inc is a proper -# dependency. Make the same true for the linker sript. bootblock-y += id.S $(call src-to-obj,bootblock,$(dir)/id.S): $(obj)/build.h @@ -132,9 +129,12 @@ else LDFLAGS_bootblock += -m elf_x86_64 --oformat elf64-x86-64 endif -bootblock-y += bootblock.S +# Add the assembly file that pulls in the rest of the dependencies in +# the right order. Make sure the auto generated bootblock.inc is a proper +# dependency. Make the same true for the linker sript. +bootblock-y += bootblock_romcc.S bootblock-y += walkcbfs.S -$(call src-to-obj,bootblock,$(dir)/bootblock.S): $(objgenerated)/bootblock.inc +$(call src-to-obj,bootblock,$(dir)/bootblock_romcc.S): $(objgenerated)/bootblock.inc bootblock-y += bootblock.ld $(call src-to-obj,bootblock,$(dir)/bootblock.ld): $(objgenerated)/bootblock.ld diff --git a/src/arch/x86/bootblock.S b/src/arch/x86/bootblock_romcc.S index 27a23ebef1..6c1723a4c1 100644 --- a/src/arch/x86/bootblock.S +++ b/src/arch/x86/bootblock_romcc.S @@ -13,9 +13,22 @@ * GNU General Public License for more details. */ -/* This file assembles the bootblock program by the order of the includes. Thus, +/* + * This is the original bootblock used by coreboot on x86 systems. It contains + * a monolithic code flow, assembled from the following stages: + * - reset16.inc: the reset vector + * - entry16.inc: protected mode setup + * - entry32.inc: segment descriptor setup + * - CONFIG_CHIPSET_BOOTBLOCK_INCLUDE: chipset-specific initialization + * - generated/bootblock.inc: ROMCC part of the bootblock + * + * This is used on platforms which do not select C_ENVIRONMENT_BOOTBLOCK, and it + * tries to do the absolute minimum before walking CBFS and jumping to romstage. + * + * This file assembles the bootblock program by the order of the includes. Thus, * it's extremely important that one pays very careful attention to the order - * of the includes. */ + * of the includes. + */ #include <arch/x86/prologue.inc> #include <cpu/x86/16bit/entry16.inc> |