summaryrefslogtreecommitdiff
path: root/src/arch
diff options
context:
space:
mode:
authorDamien Zammit <damien@zamaudio.com>2015-11-28 21:27:05 +1100
committerStefan Reinauer <stefan.reinauer@coreboot.org>2015-12-02 00:38:45 +0100
commit149c4c5d0191f1728a66ec986c3eae698cbf87cb (patch)
tree919fd67a4480497e6b1cd0ea8a0b99fdc58706cb /src/arch
parent003d15cab43fe34f1916d6f3877f2a6f2b8f6e25 (diff)
downloadcoreboot-149c4c5d0191f1728a66ec986c3eae698cbf87cb.tar.xz
x86/smm: Initialize SMM on some CPUs one-by-one
We currently race in SMM init on Atom 230 (and potentially other CPUs). At least on the 230, this leads to a hang on RSM, likely because both hyperthreads mess around with SMBASE and other SMM state variables in parallel without coordination. The same behaviour occurs with Atom D5xx. Change it so first APs are spun up and sent to sleep, then BSP initializes SMM, then every CPU, one after another. Only do this when SERIALIZE_SMM_INITIALIZATION is set. Set the flag for Atom CPUs. Change-Id: I1ae864e37546298ea222e81349c27cf774ed251f Signed-off-by: Patrick Georgi <patrick@georgi-clan.de> Signed-off-by: Damien Zammit <damien@zamaudio.com> Reviewed-on: https://review.coreboot.org/6311 Tested-by: build bot (Jenkins) Tested-by: BSI firmware lab <coreboot-labor@bsi.bund.de> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'src/arch')
-rw-r--r--src/arch/x86/cpu.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/src/arch/x86/cpu.c b/src/arch/x86/cpu.c
index ceed0770e2..52b56812d5 100644
--- a/src/arch/x86/cpu.c
+++ b/src/arch/x86/cpu.c
@@ -234,6 +234,9 @@ void cpu_initialize(unsigned int index)
die("CPU: missing cpu device structure");
}
+ if (cpu->initialized)
+ return;
+
post_log_path(cpu);
/* Find what type of cpu we are dealing with */