diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2020-07-24 15:54:31 +0300 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2020-12-02 23:35:58 +0000 |
| commit | 8c99c27df10f6c5a120e41ffb0948e357f5a2d20 (patch) | |
| tree | 710940c338b8b2a3ddebab60faf7856725ca37e2 /src/console | |
| parent | 5e053af7a677d0c1f98e624057ba7409f8492596 (diff) | |
| download | coreboot-8c99c27df10f6c5a120e41ffb0948e357f5a2d20.tar.xz | |
lib/trace: Remove TRACE support
Looks like the option is generally not compatible with
garbage collections.
Nothing gets inlined, for example is_smp_boot() no longer
evaluates to constant false and thus the symbols from
secondary.S would need to be present for the build to pass
even if we set SMP=n.
Also the addresses of relocatable ramstage are currently
not normalised on the logs, so util/genprof would be unable
dress those.
Change-Id: I0b6f310e15e6f4992cd054d288903fea8390e5cf
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45757
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/console')
| -rw-r--r-- | src/console/printk.c | 3 | ||||
| -rw-r--r-- | src/console/vsprintf.c | 5 |
2 files changed, 0 insertions, 8 deletions
diff --git a/src/console/printk.c b/src/console/printk.c index 4a3de47832..85d9bfb1e6 100644 --- a/src/console/printk.c +++ b/src/console/printk.c @@ -10,7 +10,6 @@ #include <console/vtxprintf.h> #include <smp/spinlock.h> #include <smp/node.h> -#include <trace.h> #include <timer.h> DECLARE_SPIN_LOCK(console_lock) @@ -81,7 +80,6 @@ int do_vprintk(int msg_level, const char *fmt, va_list args) if (log_this < CONSOLE_LOG_FAST) return 0; - DISABLE_TRACE; spin_lock(&console_lock); console_time_run(); @@ -96,7 +94,6 @@ int do_vprintk(int msg_level, const char *fmt, va_list args) console_time_stop(); spin_unlock(&console_lock); - ENABLE_TRACE; return i; } diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index d0c569bf59..06b9e494a4 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -2,7 +2,6 @@ #include <console/vtxprintf.h> #include <string.h> -#include <trace.h> struct vsnprintf_context { char *str_buf; @@ -24,16 +23,12 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args) int i; struct vsnprintf_context ctx; - DISABLE_TRACE; - ctx.str_buf = buf; ctx.buf_limit = size ? size - 1 : 0; i = vtxprintf(str_tx_byte, fmt, args, &ctx); if (size) *ctx.str_buf = '\0'; - ENABLE_TRACE; - return i; } |