summaryrefslogtreecommitdiff
path: root/src/console
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2018-11-11 02:51:14 +0100
committerNico Huber <nico.h@gmx.de>2019-01-09 22:15:48 +0000
commita96e66a76f21c41b0c15db8d9df1d721f4a8a9af (patch)
tree6cc4301dec4b2ca50a7c0fb43f92c60706bc7e14 /src/console
parent3910c4e4882876d70dfef08c6cc3946bc190d9ed (diff)
downloadcoreboot-a96e66a76f21c41b0c15db8d9df1d721f4a8a9af.tar.xz
soc/intel: Clean mess around UART_DEBUG
Everything is wrong here, the Kconfig symbols are only the tip of the iceberg. Based on Kconfig prompts the SoC code performed pad configu- rations! I don't see why the person who configures coreboot should have the board schematics at hand. As a mitigation, we remove the prompts for UART_DEBUG, which is renamed to INTEL_LPSS_UART_FOR_CONSOLE (because the former didn't really say what it's about), and for UART_FOR_CONSOLE in case the former is selec- ted. Change-Id: Ibe2ed3cab0bb04bb23989c22da45299f088c758b Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/29573 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Diffstat (limited to 'src/console')
-rw-r--r--src/console/Kconfig10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/console/Kconfig b/src/console/Kconfig
index e7e329848a..3db7005a10 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -48,8 +48,16 @@ if CONSOLE_SERIAL
comment "device-specific UART"
depends on HAVE_UART_SPECIAL
+config FIXED_UART_FOR_CONSOLE
+ bool
+ help
+ Select to remove the prompt from UART_FOR_CONSOLE in case a
+ specific UART has to be used (e.g. when the platform code
+ performs dangerous configurations).
+
config UART_FOR_CONSOLE
- int "Index for UART port to use for console"
+ int
+ prompt "Index for UART port to use for console" if !FIXED_UART_FOR_CONSOLE
default 0
help
Select an I/O port to use for serial console: