summaryrefslogtreecommitdiff
path: root/src/cpu/amd/car
diff options
context:
space:
mode:
authorUwe Hermann <uwe@hermann-uwe.de>2010-10-02 20:51:29 +0000
committerUwe Hermann <uwe@hermann-uwe.de>2010-10-02 20:51:29 +0000
commit36455aade46a1ca44aa1387e1785e72519f7b82d (patch)
tree73dfa0ff9ec8fcac0b45ec4cb4f6d81684d07413 /src/cpu/amd/car
parentae3f2b3706b3655627fdaee897d28ac4b5fe2659 (diff)
downloadcoreboot-36455aade46a1ca44aa1387e1785e72519f7b82d.tar.xz
Add comments to make it clear why these two lines are written like that:
movl $REAL_XIP_ROM_BASE, %eax orl $MTRR_TYPE_WRBACK, %eax Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Uwe Hermann <uwe@hermann-uwe.de> git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5908 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/cpu/amd/car')
-rw-r--r--src/cpu/amd/car/cache_as_ram.inc5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/cpu/amd/car/cache_as_ram.inc b/src/cpu/amd/car/cache_as_ram.inc
index a7bce9e91b..53182726f1 100644
--- a/src/cpu/amd/car/cache_as_ram.inc
+++ b/src/cpu/amd/car/cache_as_ram.inc
@@ -269,6 +269,11 @@ clear_fixed_var_mtrr_out:
*/
movl $MTRRphysBase_MSR(1), %ecx
xorl %edx, %edx
+ /*
+ * IMPORTANT: The two lines below can _not_ be written like this:
+ * movl $(REAL_XIP_ROM_BASE | MTRR_TYPE_WRBACK), %eax
+ * http://www.coreboot.org/pipermail/coreboot/2010-October/060855.html
+ */
movl $REAL_XIP_ROM_BASE, %eax
orl $MTRR_TYPE_WRBACK, %eax
wrmsr