summaryrefslogtreecommitdiff
path: root/src/cpu/amd
diff options
context:
space:
mode:
authorAaron Durbin <adurbin@chromium.org>2015-07-16 16:07:02 -0500
committerAaron Durbin <adurbin@chromium.org>2015-08-13 16:10:17 +0200
commit0dc7354760e889074472ef17652c7f270f3aa529 (patch)
treee909b28b3789b569b8cbe62ec10dbf167474e070 /src/cpu/amd
parentdb01ddfd49ee6177c738f410496574105e7e5e44 (diff)
downloadcoreboot-0dc7354760e889074472ef17652c7f270f3aa529.tar.xz
amd: raminit sysinfo offset fix
The sysinfo object within the k8 ram init is used to communicate progess/status from all the nodes in the system. However, the code was assuming where the sysinfo object lived in cache-as-ram. The layout of cache-as-ram is dynamic so one needs to do the lookup of the correct address at runtime. The way the amd code is compiled by #include'ing .c files makes the solution a little more complex in that some cache-as-ram support code needed to be refactored. Change-Id: I6500fa7b005dc082c4c0b3382ee2c3a138d9ac31 Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/10961 Tested-by: build bot (Jenkins) Tested-by: Raptor Engineering Automated Test Stand <noreply@raptorengineeringinc.com> Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Diffstat (limited to 'src/cpu/amd')
-rw-r--r--src/cpu/amd/car/post_cache_as_ram.c12
1 files changed, 2 insertions, 10 deletions
diff --git a/src/cpu/amd/car/post_cache_as_ram.c b/src/cpu/amd/car/post_cache_as_ram.c
index 6c320906ae..96df3e7ff8 100644
--- a/src/cpu/amd/car/post_cache_as_ram.c
+++ b/src/cpu/amd/car/post_cache_as_ram.c
@@ -3,6 +3,7 @@
*/
#include <string.h>
#include <arch/stages.h>
+#include <arch/early_variables.h>
#include <cpu/x86/mtrr.h>
#include <cpu/amd/mtrr.h>
#include <cpu/amd/car.h>
@@ -22,18 +23,9 @@
#define print_car_debug(x)
#endif
-extern char _car_data_start[];
-extern char _car_data_end[];
-
-static size_t car_data_size(void)
-{
- size_t car_size = &_car_data_end[0] - &_car_data_start[0];
- return ALIGN(car_size, 64);
-}
-
static size_t backup_size(void)
{
- size_t car_size = &_car_data_end[0] - &_car_data_start[0];
+ size_t car_size = car_data_size();
return ALIGN(car_size + 1024, 1024);
}