summaryrefslogtreecommitdiff
path: root/src/cpu/x86/lapic/secondary.S
diff options
context:
space:
mode:
authorSven Schnelle <svens@stackframe.org>2012-06-17 10:32:55 +0200
committerRonald G. Minnich <rminnich@gmail.com>2012-07-02 19:39:08 +0200
commit042c1461fb777e583e5de48edf9326e47ee5595f (patch)
tree489bf29958a39f8a0169e451c7f080e99d25eadd /src/cpu/x86/lapic/secondary.S
parent9ed1456eff73d1a268eabb84176dd2a2107bf2d7 (diff)
downloadcoreboot-042c1461fb777e583e5de48edf9326e47ee5595f.tar.xz
Use broadcast SIPI to startup siblings
The current code for initializing AP cpus has several shortcomings: - it assumes APIC IDs are sequential - it uses only the BSP for determining the AP count, which is bad if there's more than one physical CPU, and CPUs are of different type Note that the new code call cpu->ops->init() in parallel, and therefore some CPU code needs to be changed to address that. One example are old Intel HT enabled CPUs which can't do microcode update in parallel. Change-Id: Ic48a1ebab6a7c52aa76765f497268af09fa38c25 Signed-off-by: Sven Schnelle <svens@stackframe.org> Reviewed-on: http://review.coreboot.org/1139 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Diffstat (limited to 'src/cpu/x86/lapic/secondary.S')
-rw-r--r--src/cpu/x86/lapic/secondary.S20
1 files changed, 15 insertions, 5 deletions
diff --git a/src/cpu/x86/lapic/secondary.S b/src/cpu/x86/lapic/secondary.S
index dc00b082e9..67e44c46df 100644
--- a/src/cpu/x86/lapic/secondary.S
+++ b/src/cpu/x86/lapic/secondary.S
@@ -2,7 +2,7 @@
#include <cpu/x86/lapic_def.h>
.text
- .globl _secondary_start, _secondary_start_end
+ .globl _secondary_start, _secondary_start_end, cpucount
.balign 4096
_secondary_start:
.code16
@@ -38,15 +38,25 @@ _secondary_start:
/* Load the Interrupt descriptor table */
lidt idtarg
- /* Set the stack pointer, and flag that we are done */
- xorl %eax, %eax
- movl secondary_stack, %esp
- movl %eax, secondary_stack
+ /* increment our cpu index */
+ movl $1, %eax
+ lock xadd %eax, cpucount
+ incl %eax
+ movl %eax, %ecx
+
+ /* assign stack for this specific cpu */
+ mov _stack, %esp
+ mov $CONFIG_STACK_SIZE, %ebx
+ mul %ebx
+ add %eax, %esp
+ pushl %ecx
call secondary_cpu_init
1: hlt
jmp 1b
+cpucount:
+ .long 1
gdtaddr:
.word gdt_limit /* the table limit */
.long gdt /* we know the offset */