summaryrefslogtreecommitdiff
path: root/src/cpu/x86/smm
diff options
context:
space:
mode:
authorPatrick Rudolph <siro@das-labor.org>2017-06-10 08:58:00 +0200
committerMartin Roth <martinroth@google.com>2017-06-19 20:46:40 +0200
commita4677e426a78f81e2a53b374f3508f717b8b2f05 (patch)
tree79bae1f1b47775ecbdc2678fc9300a1947964d0a /src/cpu/x86/smm
parent1827ec1f4e925e89b2d2176b771385caa1a106b8 (diff)
downloadcoreboot-a4677e426a78f81e2a53b374f3508f717b8b2f05.tar.xz
cpu/x86/smm/smihandler: Apply cosmetic changes
Use define for SSA base address. Move EM64T area to 0x7c00 and add reserved area of size 0x100, as there's no indication that the address 0x7d00 exists on any platform. No functional change. Change-Id: I38c405c8977f5dd571e0da3a44fcad4738b696b2 Signed-off-by: Patrick Rudolph <siro@das-labor.org> Reviewed-on: https://review.coreboot.org/20146 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Diffstat (limited to 'src/cpu/x86/smm')
-rw-r--r--src/cpu/x86/smm/smihandler.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/src/cpu/x86/smm/smihandler.c b/src/cpu/x86/smm/smihandler.c
index 19e53e677c..16415baac1 100644
--- a/src/cpu/x86/smm/smihandler.c
+++ b/src/cpu/x86/smm/smihandler.c
@@ -153,12 +153,14 @@ void smi_handler(u32 smm_revision)
case 0x00030007:
state_save.type = LEGACY;
state_save.legacy_state_save =
- smm_save_state(smm_base, 0x7e00, node);
+ smm_save_state(smm_base,
+ SMM_LEGACY_ARCH_OFFSET, node);
break;
case 0x00030100:
state_save.type = EM64T;
state_save.em64t_state_save =
- smm_save_state(smm_base, 0x7d00, node);
+ smm_save_state(smm_base,
+ SMM_EM64T_ARCH_OFFSET, node);
break;
case 0x00030101: /* SandyBridge, IvyBridge, and Haswell */
state_save.type = EM64T101;
@@ -169,7 +171,8 @@ void smi_handler(u32 smm_revision)
case 0x00030064:
state_save.type = AMD64;
state_save.amd64_state_save =
- smm_save_state(smm_base, 0x7e00, node);
+ smm_save_state(smm_base,
+ SMM_AMD64_ARCH_OFFSET, node);
break;
default:
printk(BIOS_DEBUG, "smm_revision: 0x%08x\n", smm_revision);