diff options
| author | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-10-31 08:03:16 +1100 |
|---|---|---|
| committer | Edward O'Callaghan <eocallaghan@alterapraxis.com> | 2014-11-01 21:14:35 +0100 |
| commit | 0625a8bcfb90ae8d68c07147cc5cb3172424f601 (patch) | |
| tree | 5961b43d8efeeab4f80fad776fce9d6a376ef9c1 /src/cpu | |
| parent | 524625d4e0a6ee07b01960437a3f918c0f04a1bb (diff) | |
| download | coreboot-0625a8bcfb90ae8d68c07147cc5cb3172424f601.tar.xz | |
{cpu,soc}: Use DEVICE_NOOP macro over dummy symbol
Change-Id: Iaf2b2873bd1c52d7f936bd9b483e194a0872a626
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7285
Tested-by: build bot (Jenkins)
Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
Diffstat (limited to 'src/cpu')
| -rw-r--r-- | src/cpu/allwinner/a10/cpu.c | 8 | ||||
| -rw-r--r-- | src/cpu/amd/sc520/sc520.c | 13 |
2 files changed, 5 insertions, 16 deletions
diff --git a/src/cpu/allwinner/a10/cpu.c b/src/cpu/allwinner/a10/cpu.c index fac5730020..3159f20422 100644 --- a/src/cpu/allwinner/a10/cpu.c +++ b/src/cpu/allwinner/a10/cpu.c @@ -25,13 +25,9 @@ static void cpu_init(struct device *dev) /* TODO: Check if anything else needs to be explicitly initialized */ } -static void cpu_noop(struct device *dev) -{ -} - static struct device_operations cpu_ops = { - .read_resources = cpu_noop, - .set_resources = cpu_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, .enable_resources = cpu_enable_resources, .init = cpu_init, .scan_bus = NULL, diff --git a/src/cpu/amd/sc520/sc520.c b/src/cpu/amd/sc520/sc520.c index 808c33cdec..05215447c0 100644 --- a/src/cpu/amd/sc520/sc520.c +++ b/src/cpu/amd/sc520/sc520.c @@ -44,9 +44,6 @@ static void sc520_enable_resources(struct device *dev) { pci_write_config8(dev, PCI_COMMAND, command); command = pci_read_config8(dev, PCI_COMMAND); printk(BIOS_SPEW, "========>%s, command 0x%x\n", __func__, command); -/* - */ - } static void sc520_read_resources(device_t dev) @@ -170,14 +167,10 @@ static void cpu_bus_init(device_t dev) printk(BIOS_SPEW, "cpu_bus_init\n"); } -static void cpu_bus_noop(device_t dev) -{ -} - static struct device_operations cpu_bus_ops = { - .read_resources = cpu_bus_noop, - .set_resources = cpu_bus_noop, - .enable_resources = cpu_bus_noop, + .read_resources = DEVICE_NOOP, + .set_resources = DEVICE_NOOP, + .enable_resources = DEVICE_NOOP, .init = cpu_bus_init, .scan_bus = 0, }; |