diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-01-11 18:51:35 +0200 |
|---|---|---|
| committer | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2019-01-23 09:35:08 +0000 |
| commit | ec576d1c978a3d2f7f4eee12eda660aec18c0b2c (patch) | |
| tree | 7ab6a421dacdf846b4aa678dab98c22901b6e726 /src/cpu | |
| parent | 0a656f033bbfb2c518b3a351d659d1585985c5b6 (diff) | |
| download | coreboot-ec576d1c978a3d2f7f4eee12eda660aec18c0b2c.tar.xz | |
arch/x86: Align _start16bit with C_ENVIRONMENT_BOOBLOCK
Followup removes SIPI_VECTOR_IN_ROM and it seems reasonable
enough to force the alignment unconditionally to page size.
Reason for the conditionals is the alignment is not possible
with romcc bootblocks having total size less than 4 kiB.
Change-Id: I0ff2786f80a319ebb3215d4fd696cda3e15c3012
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/30855
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/cpu')
| -rw-r--r-- | src/cpu/x86/16bit/entry16.inc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/cpu/x86/16bit/entry16.inc b/src/cpu/x86/16bit/entry16.inc index 55d9bd97e2..2a9f8c55e9 100644 --- a/src/cpu/x86/16bit/entry16.inc +++ b/src/cpu/x86/16bit/entry16.inc @@ -29,7 +29,8 @@ #include <arch/rom_segs.h> -#if IS_ENABLED(CONFIG_SIPI_VECTOR_IN_ROM) +#if IS_ENABLED(CONFIG_C_ENVIRONMENT_BOOTBLOCK) || \ + IS_ENABLED(CONFIG_SIPI_VECTOR_IN_ROM) /* Symbol _start16bit must be aligned to 4kB to start AP CPUs with * Startup IPI message without RAM. */ |