diff options
| author | Patrick Georgi <pgeorgi@google.com> | 2017-09-22 18:21:52 +0200 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2017-09-22 17:24:39 +0000 |
| commit | a2248cbf9ab1de22862a73e1d52d5a2361d55c51 (patch) | |
| tree | 940548684064fb72f30905c6d7f90609d30d664e /src/device/dram/ddr2.c | |
| parent | fdddc463cec6eb10e85b5dd42edf13faceb35fe0 (diff) | |
| download | coreboot-a2248cbf9ab1de22862a73e1d52d5a2361d55c51.tar.xz | |
device/dram/ddr2: Add break to several case statements that lack it
For all valid SPD values the same decoded tRR was returned.
Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Found-by: Coverity Scan #1381369, #1381370, 1381371, 1381372, 1381373
Reviewed-on: https://review.coreboot.org/21642
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Diffstat (limited to 'src/device/dram/ddr2.c')
| -rw-r--r-- | src/device/dram/ddr2.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index 6f43563b6e..2dab681754 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -194,16 +194,22 @@ static int spd_decode_tRR_time(u32 *tRR, u8 c) return CB_ERR; case 0x80: *tRR = 15625 << 8; + break; case 0x81: *tRR = 15625 << 6; + break; case 0x82: *tRR = 15625 << 7; + break; case 0x83: *tRR = 15625 << 9; + break; case 0x84: *tRR = 15625 << 10; + break; case 0x85: *tRR = 15625 << 11; + break; } return CB_SUCCESS; } |