summaryrefslogtreecommitdiff
path: root/src/device
diff options
context:
space:
mode:
authorMartin Roth <martinroth@chromium.org>2020-01-21 08:57:00 -0700
committerPatrick Georgi <pgeorgi@google.com>2020-03-17 08:23:41 +0000
commitb6e2afb1ffe7683118ba879ca19ef6343f641d17 (patch)
tree1150c9a73f4529ff91a2b0d5a3a139d57897d474 /src/device
parentbfb0f755b9fa0bf25b4575b39db348121431f325 (diff)
downloadcoreboot-b6e2afb1ffe7683118ba879ca19ef6343f641d17.tar.xz
src/device/pci_rom.c: Show device IDs on oprom failure
On a device/option-rom ID mismatch, the option rom's IDs would get shown twice instead of showing the actual device's IDs. This was very confusing because the error showed matching IDs. BUG=None TEST=Shows mismatched IDs when option rom doesn't match the hardware Change-Id: I5a06d6a7319aa653c8a5e32ec3c5afb651d83140 Signed-off-by: Martin Roth <martinroth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+/2013180 Reviewed-by: Raul E Rangel <rrangel@chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/39586 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Raul Rangel <rrangel@chromium.org> Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Diffstat (limited to 'src/device')
-rw-r--r--src/device/pci_rom.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c
index 816255d5e1..27f2d8dca2 100644
--- a/src/device/pci_rom.c
+++ b/src/device/pci_rom.c
@@ -98,7 +98,7 @@ struct rom_header *pci_rom_probe(struct device *dev)
|| dev->device != rom_data->device)
&& (vendev == mapped_vendev)) {
printk(BIOS_ERR, "ID mismatch: vendor ID %04x, "
- "device ID %04x\n", rom_data->vendor, rom_data->device);
+ "device ID %04x\n", dev->vendor, dev->device);
return NULL;
}