diff options
| author | Felix Held <felix-coreboot@felixheld.de> | 2019-12-15 13:53:48 +0100 |
|---|---|---|
| committer | Felix Held <felix-coreboot@felixheld.de> | 2019-12-16 13:40:05 +0000 |
| commit | 7b7bc59f2016264d02fa245341e3507539dcac8f (patch) | |
| tree | 3467e3891200b2d652901159c84fe22e7aaae303 /src/device | |
| parent | 116a837818897d5f1f0c76021d48532133e8f5f6 (diff) | |
| download | coreboot-7b7bc59f2016264d02fa245341e3507539dcac8f.tar.xz | |
device/pnp: introduce and use PNP_SKIP_FUNCTION
-1 shouldn't be assigned to an unsigned variable, so use an otherwise
unused constant here. Since 7 is the highest virtual LDN number, using
0xffff as PNP_SKIP_FUNCTION marker has no unwanted side effects.
Change-Id: I5e31e7ef9dad5fedfd5552963c298336c533a5e9
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/37741
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Diffstat (limited to 'src/device')
| -rw-r--r-- | src/device/pnp_device.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/device/pnp_device.c b/src/device/pnp_device.c index 28a45d0692..1852fc1b16 100644 --- a/src/device/pnp_device.c +++ b/src/device/pnp_device.c @@ -370,7 +370,7 @@ void pnp_enable_devices(struct device *base_dev, struct device_operations *ops, /* Setup the ops and resources on the newly allocated devices. */ for (i = 0; i < functions; i++) { /* Skip logical devices this Super I/O doesn't have. */ - if (info[i].function == -1) + if (info[i].function == PNP_SKIP_FUNCTION) continue; path.pnp.device = info[i].function; |