summaryrefslogtreecommitdiff
path: root/src/device
diff options
context:
space:
mode:
authorEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-11-08 09:35:31 +1100
committerEdward O'Callaghan <eocallaghan@alterapraxis.com>2014-11-08 07:09:34 +0100
commit31cef1f46e5caa63794709c381a68ac1a9394bbb (patch)
tree0dea86d18915c22ea93e8d58d3d4e699c6ffc82a /src/device
parentcfa06c746023fbb79169260012539253811525aa (diff)
downloadcoreboot-31cef1f46e5caa63794709c381a68ac1a9394bbb.tar.xz
device/dram/ddr3.c: Fix sizeof on array func param overflow
The sizeof on array function parameter will return size of 'u8 *' instead of 'spd_raw_data' (aka 'u8 [256]' leading to an overflow. Found-by: Clang Change-Id: I78e113a640b2953c853eb43bd6874e4694260b1f Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com> Reviewed-on: http://review.coreboot.org/7353 Tested-by: build bot (Jenkins) Reviewed-by: Vladimir Serbinenko <phcoder@gmail.com>
Diffstat (limited to 'src/device')
-rw-r--r--src/device/dram/ddr3.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/device/dram/ddr3.c b/src/device/dram/ddr3.c
index a43caed5ab..00f2ba9009 100644
--- a/src/device/dram/ddr3.c
+++ b/src/device/dram/ddr3.c
@@ -127,7 +127,7 @@ int spd_decode_ddr3(dimm_attr * dimm, spd_raw_data spd)
}
dimm->dram_type = SPD_MEMORY_TYPE_SDRAM_DDR3;
- crc = spd_ddr3_calc_crc(spd, sizeof(spd));
+ crc = spd_ddr3_calc_crc(spd, sizeof(*spd));
/* Compare with the CRC in the SPD */
spd_crc = (spd[127] << 8) + spd[126];
/* Verify the CRC is correct */