Random cosmetic fixes (trivial).

 - Fix typos.
 - Whitespace and consistency fixes.
 - Make "menuconfig" help easily readable in 80x25 terminals / xterms.
 - Use full/correct prototype for cbfs_and_run_core() everywhere.
 - More cosmetic fixes in license headers.
 
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5146 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1

1 files changed, 67 insertions, 46 deletions

diff --git a/src/devices/Kconfig b/src/devices/Kconfig
index 8211bf30f5..08e532d12c 100644
--- a/src/devices/Kconfig
+++ b/src/devices/Kconfig
@@ -59,15 +59,19 @@ config PCI_OPTION_ROM_RUN_REALMODE
 	  (only works on x86/x64 systems)
 
 config PCI_OPTION_ROM_RUN_YABEL
-	prompt "Secure Mode"
+	prompt "Secure mode"
 	bool
 	help
 	  If you select this option, the x86emu CPU emulator will be used to
 	  execute PCI option ROMs.
-	  This option prevents option ROMs from doing dirty tricks with the 
-	  system (such as installing SMM modules or hypervisors), but it is also
-	  significantly slower than the native option ROM initialization method.
+
+	  This option prevents option ROMs from doing dirty tricks with the
+	  system (such as installing SMM modules or hypervisors), but it is
+	  also significantly slower than the native option ROM initialization
+	  method.
+
 	  This is the default choice for non-x86 systems.
+
 endchoice
 
 # TODO: Describe better, and/or make a "choice" selection for this.
@@ -77,50 +81,65 @@ config YABEL_DEBUG_FLAGS
 	default 0x0
 	depends on PCI_OPTION_ROM_RUN_YABEL
 	help
-	  Set CONFIG_YABEL_DEBUG_FLAGS is a binary switch that allows you
+	  CONFIG_YABEL_DEBUG_FLAGS is a binary switch that allows you
 	  to select the following items to debug. 1=on 0=off. After you
-	  decide what you want to debug create the binary value, convert to hex
-	  and set the Option (Ex. CONFIG_YABEL_DEBUG_FLAGS = 0x31FF //Debug All).
+	  decide what you want to debug create the binary value, convert to
+	  hex and set the option.
 
-	  |-DEBUG_JMP - print info about JMP and RETF opcodes from x86emu
-	  ||-DEBUG_TRACE_X86EMU - print _all_ opcodes that are executed by x86emu (WARNING: this will produce a LOT of output)
+	  Example for "debug all":
+	    CONFIG_YABEL_DEBUG_FLAGS = 0x31FF
+
+	  |-DEBUG_JMP - Print info about JMP and RETF opcodes from x86emu
+	  ||-DEBUG_TRACE_X86EMU - Print _all_ opcodes that are executed by
+	  ||                      x86emu (WARNING: this will produce a LOT
+	  ||                      of output)
 	  |||-Currently unused
 	  ||||-Currently unused
 	  |||||-Currently unused
-	  ||||||-DEBUG_PNP - Print Plug And Play access made by option rom 
+	  ||||||-DEBUG_PNP - Print Plug And Play accesses made by option ROM
 	  |||||||-DEBUG_DISK - Print Disk I/O related messages, currently unused
-	  ||||||||-DEBUG_PMM - Print messages related to POST Memory Manager (PMM)
-	  |||||||||-DEBUG_VBE - Print messages related to VESA BIOS Extension (VBE) functions
-	  ||||||||||-DEBUG_PRINT_INT10 - let INT10 (i.e. character output) calls print messages to Debug output
+	  ||||||||-DEBUG_PMM - Print messages related to POST Memory
+	  ||||||||             Manager (PMM)
+	  |||||||||-DEBUG_VBE - Print messages related to VESA BIOS Extension
+	  |||||||||             (VBE) functions
+	  ||||||||||-DEBUG_PRINT_INT10 - Let INT10 (i.e. character output)
+	  ||||||||||                     calls print messages to debug output
 	  |||||||||||-DEBUG_INTR - Print messages related to interrupt handling
-	  ||||||||||||-DEBUG_CHECK_VMEM_ACCESS - Print messages related to accesse to certain areas of the virtual Memory (e.g. BDA (BIOS Data Area) or Interrupt Vectors)
-	  |||||||||||||-DEBUG_MEM - Print memory access made by option rom (NOTE: this also includes accesses to fetch instructions)
-	  ||||||||||||||-DEBUG_IO - Print I/O access made by option rom 
-	  11000111111111 - Max Binary Value, Debug All (WARNING: - This could run for hours)
-	
-	  DEBUG_IO		  0x0001
-	  DEBUG_MEM		  0x0002
-	  DEBUG_CHECK_VMEM_ACCESS 0x0004
-	  DEBUG_INTR		  0x0008
-	  DEBUG_PRINT_INT10	  0x0010
-	  DEBUG_VBE		  0x0020
-	  DEBUG_PMM		  0x0040
-	  DEBUG_DISK		  0x0080
-	  DEBUG_PNP		  0x0100
-	  DEBUG_TRACE_X86EMU	  0x1000
-	  DEBUG_JMP		  0x2000
-
-	  See debug.h for values 0 is no debug output, 0x31ff is _verbose_.
+	  ||||||||||||-DEBUG_CHECK_VMEM_ACCESS - Print messages related to
+	  ||||||||||||                           accesses to certain areas of
+	  ||||||||||||                           the virtual memory (e.g. BDA
+	  ||||||||||||                           (BIOS Data Area) or interrupt
+	  ||||||||||||                           vectors)
+	  |||||||||||||-DEBUG_MEM - Print memory accesses made by option ROM
+	  |||||||||||||             (NOTE: this also includes accesses to
+	  |||||||||||||             fetch instructions)
+	  ||||||||||||||-DEBUG_IO - Print I/O accesses made by option ROM
+	  11000111111111 - Maximum binary value, i.e. "debug all"
+	                   (WARNING: This could run for hours)
+
+	  DEBUG_IO			0x0001
+	  DEBUG_MEM			0x0002
+	  DEBUG_CHECK_VMEM_ACCESS	0x0004
+	  DEBUG_INTR			0x0008
+	  DEBUG_PRINT_INT10		0x0010
+	  DEBUG_VBE			0x0020
+	  DEBUG_PMM			0x0040
+	  DEBUG_DISK			0x0080
+	  DEBUG_PNP			0x0100
+	  DEBUG_TRACE_X86EMU		0x1000
+	  DEBUG_JMP			0x2000
+
+	  See debug.h for values. 0 is no debug output, 0x31ff is _verbose_.
 
 config YABEL_PCI_ACCESS_OTHER_DEVICES
-	prompt "Allow option roms to acces other devices"
+	prompt "Allow option ROMs to access other devices"
 	bool
 	depends on PCI_OPTION_ROM_RUN_YABEL
 	help
-	  Per default, YABEL only allows option roms to access the PCI device
+	  Per default, YABEL only allows option ROMs to access the PCI device
 	  that they are associated with. However, this causes trouble for some
-	  onboard graphics chips whose option rom needs to reconfigure the 
-	  north bridge. 
+	  onboard graphics chips whose option ROM needs to reconfigure the
+	  north bridge.
 
 config YABEL_VIRTMEM_LOCATION
 	prompt "Location of YABEL's virtual memory"
@@ -132,16 +151,17 @@ config YABEL_VIRTMEM_LOCATION
 	  normally located at 16MB.
 
 config YABEL_DIRECTHW
-	prompt "Direct Hardware Access"
+	prompt "Direct hardware access"
 	bool
 	depends on PCI_OPTION_ROM_RUN_YABEL
 	help
 	  YABEL consists of two parts: It uses x86emu for the CPU emulation and
-	  additionally provides a PC system emulation that filters bad device and
-	  memory access (such as PCI config space access to other devices than the
-	  initialized one).
+	  additionally provides a PC system emulation that filters bad device
+	  and memory access (such as PCI config space access to other devices
+	  than the initialized one).
+
 	  When choosing this option, x86emu will pass through all hardware
-	  accesses to memory and IO devices to the underlying memory and IO
+	  accesses to memory and I/O devices to the underlying memory and I/O
 	  addresses. While this option prevents option ROMs from doing dirty
 	  tricks with the CPU (such as installing SMM modules or hypervisors),
 	  they can still access all devices in the system.
@@ -153,8 +173,9 @@ config BOOTSPLASH
 	depends on PCI_OPTION_ROM_RUN_YABEL
 	help
 	  This option shows a graphical bootsplash screen. The grapics are
-	  loaded from the CBFS file bootsplash.jpg
+	  loaded from the CBFS file bootsplash.jpg.
 
+# TODO: Turn this into a "choice".
 config FRAMEBUFFER_VESA_MODE
 	prompt "VESA framebuffer video mode"
 	hex
@@ -162,7 +183,7 @@ config FRAMEBUFFER_VESA_MODE
 	depends on BOOTSPLASH
 	help
 	  This option sets the resolution used for the coreboot framebuffer and
-	  bootsplash screen. Set to 0x117 for 1024x768x16. A diligent soul will 
+	  bootsplash screen. Set to 0x117 for 1024x768x16. A diligent soul will
 	  some day make this a "choice".
 
 config COREBOOT_KEEP_FRAMEBUFFER
@@ -171,10 +192,10 @@ config COREBOOT_KEEP_FRAMEBUFFER
 	depends on BOOTSPLASH
 	help
 	  This option keeps the framebuffer mode set after coreboot finishes
-	  execution. If this option is enabled, coreboot will pass a framebuffer
-	  entry in its coreboot table and the payload will need a framebuffer
-	  driver. If this option is disabled, coreboot will switch back to 
-	  text mode before handing control to a payload.
+	  execution. If this option is enabled, coreboot will pass a
+	  framebuffer entry in its coreboot table and the payload will need a
+	  framebuffer driver. If this option is disabled, coreboot will switch
+	  back to text mode before handing control to a payload.
 
 config CONSOLE_VGA_MULTI
 	bool