diff options
| author | Kyösti Mälkki <kyosti.malkki@gmail.com> | 2012-07-07 17:15:51 +0300 |
|---|---|---|
| committer | Stefan Reinauer <stefan.reinauer@coreboot.org> | 2012-07-10 19:52:24 +0200 |
| commit | a5650a4b4ac85722d772083761ffea32557774b4 (patch) | |
| tree | 188f35747cf3f64d157bf7ef99e233d8dc6c27a2 /src/devices/device_util.c | |
| parent | da09be6328505ac4473aff48b8ef27b9986bfa22 (diff) | |
| download | coreboot-a5650a4b4ac85722d772083761ffea32557774b4.tar.xz | |
Use dev_lock for alloc_find_dev()
If threads called alloc_find_dev() with same device_path
simultaneously, two device nodes could be allocated.
This bug is not triggered by current code.
Change-Id: Ifc87021c8d6f422901c5de5dd17392e3e2309afa
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/1188
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
Reviewed-by: Sven Schnelle <svens@stackframe.org>
Diffstat (limited to 'src/devices/device_util.c')
| -rw-r--r-- | src/devices/device_util.c | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/src/devices/device_util.c b/src/devices/device_util.c index 5225938e19..ecc2c13659 100644 --- a/src/devices/device_util.c +++ b/src/devices/device_util.c @@ -48,22 +48,6 @@ device_t find_dev_path(struct bus *parent, struct device_path *path) } /** - * See if a device structure already exists and if not allocate it. - * - * @param parent The bus to find the device on. - * @param path The relative path from the bus to the appropriate device. - * @return Pointer to a device structure for the device on bus at path. - */ -device_t alloc_find_dev(struct bus *parent, struct device_path *path) -{ - device_t child; - child = find_dev_path(parent, path); - if (!child) - child = alloc_dev(parent, path); - return child; -} - -/** * Given a PCI bus and a devfn number, find the device structure. * * @param bus The bus number. |