diff options
| author | Uwe Hermann <uwe@hermann-uwe.de> | 2009-10-27 21:49:33 +0000 |
|---|---|---|
| committer | Uwe Hermann <uwe@hermann-uwe.de> | 2009-10-27 21:49:33 +0000 |
| commit | 312673ca729f2b3557a572a03ff6915460329286 (patch) | |
| tree | db628d0ff9db6b4824afcd84a6546ef90dad25bb /src/devices | |
| parent | a8888bd1d236af51dae1b39a5d7bc9dd8b9b4f2e (diff) | |
| download | coreboot-312673ca729f2b3557a572a03ff6915460329286.tar.xz | |
Improve coreboot build output and eliminate some warnings:
- Add static and const where possible.
- Turn some #warning entries into TODO comments.
- Add missing prototypes.
- Remove unused variables.
- Fix printf arguments or cast them as needed.
- Make sconfig output look better. Drop useless "PARSED THE TREE" output.
- Print "(this may take a while)" while building romcc. Add missing "\n".
Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Myles Watosn <mylesgw@gmail.com>
git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4874 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'src/devices')
| -rw-r--r-- | src/devices/device.c | 7 | ||||
| -rw-r--r-- | src/devices/pci_device.c | 2 | ||||
| -rw-r--r-- | src/devices/pciexp_device.c | 4 |
3 files changed, 8 insertions, 5 deletions
diff --git a/src/devices/device.c b/src/devices/device.c index 2f01ae2df2..2323850ae6 100644 --- a/src/devices/device.c +++ b/src/devices/device.c @@ -671,8 +671,11 @@ static void avoid_fixed_resources(struct device *dev) device_t vga_pri = 0; static void set_vga_bridge_bits(void) { -#warning "FIXME modify set_vga_bridge so it is less pci centric!" -#warning "This function knows too much about PCI stuff, it should be just a iterator/visitor." + /* + * FIXME: Modify set_vga_bridge so it is less PCI centric! + * This function knows too much about PCI stuff, it should be just + * an iterator/visitor. + */ /* FIXME: Handle the VGA palette snooping. */ struct device *dev, *vga, *vga_onboard, *vga_first, *vga_last; diff --git a/src/devices/pci_device.c b/src/devices/pci_device.c index 5c73db5ed0..1788044fe7 100644 --- a/src/devices/pci_device.c +++ b/src/devices/pci_device.c @@ -809,7 +809,7 @@ static void set_pci_ops(struct device *dev) for (driver = &pci_drivers[0]; driver != &epci_drivers[0]; driver++) { if ((driver->vendor == dev->vendor) && (driver->device == dev->device)) { - dev->ops = driver->ops; + dev->ops = (struct device_operations *)driver->ops; printk_spew("%s [%04x/%04x] %sops\n", dev_path(dev), driver->vendor, driver->device, diff --git a/src/devices/pciexp_device.c b/src/devices/pciexp_device.c index 909026a365..461c3b6c7a 100644 --- a/src/devices/pciexp_device.c +++ b/src/devices/pciexp_device.c @@ -34,8 +34,8 @@ static void pciexp_tune_dev(device_t dev) /* error... */ return; } - printk_debug("PCIe: tuning %s\n", dev_path(dev)); -#warning "IMPLEMENT PCI EXPRESS TUNING" + // printk_debug("PCIe: tuning %s\n", dev_path(dev)); + /* TODO: Implement PCI Express tuning. */ } unsigned int pciexp_scan_bus(struct bus *bus, |