summaryrefslogtreecommitdiff
path: root/src/drivers/generic
diff options
context:
space:
mode:
authorNico Huber <nico.h@gmx.de>2020-04-05 14:05:24 +0200
committerAngel Pons <th3fanbus@gmail.com>2020-04-10 11:50:22 +0000
commit2f8ba69b0ee5deafa9bad20c2a7b2b4785fcb565 (patch)
tree05ed912a3b8e0d11daa2d83030f93d9e90d46d90 /src/drivers/generic
parenta461b694a6c0468cd679628aeebf83437027fb45 (diff)
downloadcoreboot-2f8ba69b0ee5deafa9bad20c2a7b2b4785fcb565.tar.xz
Replace DEVICE_NOOP with noop_(set|read)_resources
`.read_resources` and `.set_resources` are the only two device operations that are considered mandatory. Other function pointers can be left NULL. Having dedicated no-op implementations for the two mandatory fields should stop the leaking of no-op pointers to other fields. Change-Id: I6469a7568dc24317c95e238749d878e798b0a362 Signed-off-by: Nico Huber <nico.h@gmx.de> Reviewed-on: https://review.coreboot.org/c/coreboot/+/40207 Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr> Reviewed-by: Edward O'Callaghan <quasisec@chromium.org> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Diffstat (limited to 'src/drivers/generic')
-rw-r--r--src/drivers/generic/adau7002/adau7002.c4
-rw-r--r--src/drivers/generic/generic/generic.c4
-rw-r--r--src/drivers/generic/gpio_keys/gpio_keys.c4
-rw-r--r--src/drivers/generic/gpio_regulator/gpio_regulator.c4
-rw-r--r--src/drivers/generic/ioapic/ioapic.c2
-rw-r--r--src/drivers/generic/max98357a/max98357a.c4
6 files changed, 11 insertions, 11 deletions
diff --git a/src/drivers/generic/adau7002/adau7002.c b/src/drivers/generic/adau7002/adau7002.c
index 97bd37d871..aa47ae6bb9 100644
--- a/src/drivers/generic/adau7002/adau7002.c
+++ b/src/drivers/generic/adau7002/adau7002.c
@@ -55,8 +55,8 @@ static const char *adau7002_acpi_name(const struct device *dev)
#endif
static struct device_operations adau7002_ops = {
- .read_resources = DEVICE_NOOP,
- .set_resources = DEVICE_NOOP,
+ .read_resources = noop_read_resources,
+ .set_resources = noop_set_resources,
#if CONFIG(HAVE_ACPI_TABLES)
.acpi_name = adau7002_acpi_name,
.acpi_fill_ssdt = adau7002_fill_ssdt,
diff --git a/src/drivers/generic/generic/generic.c b/src/drivers/generic/generic/generic.c
index d4de6c7583..cee41a538b 100644
--- a/src/drivers/generic/generic/generic.c
+++ b/src/drivers/generic/generic/generic.c
@@ -68,8 +68,8 @@ static const char *generic_dev_acpi_name(const struct device *dev)
}
static struct device_operations generic_dev_ops = {
- .read_resources = DEVICE_NOOP,
- .set_resources = DEVICE_NOOP,
+ .read_resources = noop_read_resources,
+ .set_resources = noop_set_resources,
.acpi_name = generic_dev_acpi_name,
.acpi_fill_ssdt = generic_dev_fill_ssdt_generator,
};
diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c
index 5a74c6409b..b8e72bf328 100644
--- a/src/drivers/generic/gpio_keys/gpio_keys.c
+++ b/src/drivers/generic/gpio_keys/gpio_keys.c
@@ -102,8 +102,8 @@ static const char *gpio_keys_acpi_name(const struct device *dev)
}
static struct device_operations gpio_keys_ops = {
- .read_resources = DEVICE_NOOP,
- .set_resources = DEVICE_NOOP,
+ .read_resources = noop_read_resources,
+ .set_resources = noop_set_resources,
.acpi_name = gpio_keys_acpi_name,
.acpi_fill_ssdt = gpio_keys_fill_ssdt_generator,
};
diff --git a/src/drivers/generic/gpio_regulator/gpio_regulator.c b/src/drivers/generic/gpio_regulator/gpio_regulator.c
index 7041aa0e7c..0f39910b85 100644
--- a/src/drivers/generic/gpio_regulator/gpio_regulator.c
+++ b/src/drivers/generic/gpio_regulator/gpio_regulator.c
@@ -59,8 +59,8 @@ static const char *gpio_regulator_acpi_name(const struct device *dev)
}
static struct device_operations gpio_regulator_ops = {
- .read_resources = DEVICE_NOOP,
- .set_resources = DEVICE_NOOP,
+ .read_resources = noop_read_resources,
+ .set_resources = noop_set_resources,
.acpi_name = gpio_regulator_acpi_name,
.acpi_fill_ssdt = gpio_regulator_fill_ssdt_generator,
};
diff --git a/src/drivers/generic/ioapic/ioapic.c b/src/drivers/generic/ioapic/ioapic.c
index b2c4bb60b1..c8be606458 100644
--- a/src/drivers/generic/ioapic/ioapic.c
+++ b/src/drivers/generic/ioapic/ioapic.c
@@ -95,7 +95,7 @@ static void ioapic_read_resources(struct device *dev)
static struct device_operations ioapic_operations = {
.read_resources = ioapic_read_resources,
- .set_resources = DEVICE_NOOP,
+ .set_resources = noop_set_resources,
.init = ioapic_init,
};
diff --git a/src/drivers/generic/max98357a/max98357a.c b/src/drivers/generic/max98357a/max98357a.c
index 0a29367498..599acb5afe 100644
--- a/src/drivers/generic/max98357a/max98357a.c
+++ b/src/drivers/generic/max98357a/max98357a.c
@@ -70,8 +70,8 @@ static const char *max98357a_acpi_name(const struct device *dev)
#endif
static struct device_operations max98357a_ops = {
- .read_resources = DEVICE_NOOP,
- .set_resources = DEVICE_NOOP,
+ .read_resources = noop_read_resources,
+ .set_resources = noop_set_resources,
#if CONFIG(HAVE_ACPI_TABLES)
.acpi_name = max98357a_acpi_name,
.acpi_fill_ssdt = max98357a_fill_ssdt,